Don't load eyaml when SECRET_KEY_BASE_DUMMY env var is set #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svanhesteren
force-pushed
the
support-secret-key-base-dummy
branch
from
bd83e66
to
00152d2
Compare
when SECRET_KEY_BASE_DUMMY env var is set
svanhesteren
force-pushed
the
support-secret-key-base-dummy
branch
from
00152d2
to
a3fe2c8
Compare
julik
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since rails can run asset precompilation in production without having a master key set by setting SECRET_KEY_BASE_DUMMY, eyaml should do so too. This env var will skip loading the eyaml/ejson files during the rails environment loading so you don't end up with an error if you don't have keys set in your CI for example.
This can be handy for things like migrations/asset precompilation where secrets are not needed anyway.
See rails/rails#46760 for the reason behind SECRET_KEY_BASE_DUMMY
Addresses #42