Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHPUnit 10 Shift #59

Merged
merged 4 commits into from
Mar 15, 2024
Merged

PHPUnit 10 Shift #59

merged 4 commits into from
Mar 15, 2024

Conversation

chelout
Copy link
Owner

@chelout chelout commented Mar 15, 2024

This pull request contains changes for upgrading to PHPUnit 10 automated by the PHPUnit 10 Shift.

Before merging, you need to:

  • Checkout the shift-112732 branch
  • Review all pull request comments for additional changes
  • Run composer update (if the scripts fail, try with --no-scripts)
  • Run your tests suite: vendor/bin/phpunit

If there were changes you felt could have been automated, please reply to the follow-up email with your feedback or on Twitter.

@chelout
Copy link
Owner Author

chelout commented Mar 15, 2024

⚠️ PHPUnit 10 has made several changes to the configuration file. After running composer update, you may run vendor/bin/phpunit --migrate-configuration to have PHPUnit upgrade your configuration file.

@chelout
Copy link
Owner Author

chelout commented Mar 15, 2024

❌ PHPUnit 10 has removed the --verbose option. Shift detected potential uses of this option in the following files. You should review these files and remove the --verbose option when calling phpunit.

  • composer.json

@chelout
Copy link
Owner Author

chelout commented Mar 15, 2024

ℹ️ PHPUnit has documented using return types for test cases and data providers since PHPUnit 8. In an effort to modernize your test suite, Shift added a return type of void to your test cases and a return type of array to your data providers.

Shift understands developers have different preferences when it comes to type hints. If you do not wish to add return types, you may undo this change by running: git revert de3a5fc0

@chelout
Copy link
Owner Author

chelout commented Mar 15, 2024

ℹ️ PHPUnit has documented declaring test classes as final since PHPUnit 8. In an effort to modernize your test suite, Shift has declared your test classes as final.

Shift understands developers have different preferences when it comes to using final. If you do not wish to declare your test classes as final, you may undo this change by running: git revert 2a3c1fb8

@chelout
Copy link
Owner Author

chelout commented Mar 15, 2024

⚠️ PHPUnit 10 now requires any base test class to have a TestCase suffix. In addition, this class should be defined as abstract. If you have a custom base test class, you should ensure it meets these new requirements.

@chelout
Copy link
Owner Author

chelout commented Mar 15, 2024

⚗️ This Shift is still being refined. Please report any issues or suggestions to [email protected]. Your feedback is what helps improve the experience for everyone.

@chelout chelout merged commit 8173910 into laravel-11 Mar 15, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants