Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using webpack 5, cannot import this package. #12

Open
leokolezhuk opened this issue Oct 7, 2022 · 2 comments
Open

When using webpack 5, cannot import this package. #12

leokolezhuk opened this issue Oct 7, 2022 · 2 comments

Comments

@leokolezhuk
Copy link

Upgraded to webpack 5.7 from 4.x and VueCli 5 from 4.

In an es module using the js-graph-algorithms package.
const jsgraphs = require('js-graph-algorithms');
In this case jsgraphs is an empty object and errors are raised like
Cannot read property Graph of undefined when trying to access jsgraphs.Graph.

This is caused by the way jsgraphs object is exported in src/jsgraphs.js
The code var module = module || {}; if(module) { module.exports = jsgraphs; }
seems to confuse webpack.

If I change this code to a normal commonjs export:
module.exports = jsgraphs;
without any extra logic, everything works normally.

@leokolezhuk
Copy link
Author

As a workaround, patching this package upon installation with patch-package.

The patch I use is the following:

  diff --git a/node_modules/js-graph-algorithms/src/jsgraphs.js b/node_modules/js-graph-algorithms/src/jsgraphs.js
  index 5409240..3c8f82b 100644
  --- a/node_modules/js-graph-algorithms/src/jsgraphs.js
  +++ b/node_modules/js-graph-algorithms/src/jsgraphs.js
  @@ -1202,7 +1202,4 @@ var jsgraphs = jsgraphs || {};
       jss.FordFulkerson = FordFulkerson;
   })(jsgraphs);
   
  -var module = module || {};
  -if(module) {
  -	module.exports = jsgraphs;
  -}
  \ No newline at end of file
  +module.exports = jsgraphs;

@NilsBaumgartner1994
Copy link

Also having this problem

backspace added a commit to backspace/adventure-gathering that referenced this issue Feb 3, 2023
backspace added a commit to backspace/adventure-gathering that referenced this issue Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants