Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not responsive #13

Open
julian-ca opened this issue May 25, 2018 · 3 comments
Open

not responsive #13

julian-ca opened this issue May 25, 2018 · 3 comments

Comments

@julian-ca
Copy link

why is it not responsive?

@connecteev
Copy link

I agree, I just realized that vodal (as good as it is) is not responsive! We're in 2019 so this is a requirement for all web developers.

@chenjiahan Can we please add the ability for width and height to be specified as percentages? And also make vodal responsive by default?

                    <vodal measure="em" :show="show" animation="slideDown" :width="60" :height="27" :customStyles="{'box\-shadow': '0px 0px 30px 3px rgba(0, 0, 0, .8)'}" :closeOnEsc="true" :duration="600" className="my-dialog" @hide="hideModal">

@chenjiahan
Copy link
Owner

you can use measure props to specify that. The default behavior should not be changed because it will cause breaking change.

@connecteev
Copy link

@chenjiahan the measure props are in px only, that doesn't work for resizing the window in a "fluid" manner. We'll have to add multiple media queries...is it possible to add an option for '%' or 'em' to the measure props, so it is not a breaking change?

measure | string | px | measure of width and height
-- | -- | -- | --

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants