You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think that reacting to SIGINT, or SIGBREAK / CTRL_C_EVENT / CTRL_BREAK_EVENT for Windows, would be more predictable than CPython's default handler that throws a KeyboardInterrupt in arbitrary moments in time.
While on it, looking into handling SIGTSTP / SIGCONT could be useful as well.
A related thought: should the server interruption flow raise a CherrotServerInterrupt, inherited from something like InterruptedError (or KeyboardInterrupt)?
I think that reacting to
SIGINT
, orSIGBREAK
/CTRL_C_EVENT
/CTRL_BREAK_EVENT
for Windows, would be more predictable than CPython's default handler that throws aKeyboardInterrupt
in arbitrary moments in time.While on it, looking into handling
SIGTSTP
/SIGCONT
could be useful as well.A related thought: should the server interruption flow raise a
CherrotServerInterrupt
, inherited from something likeInterruptedError
(orKeyboardInterrupt
)?Refs:
The text was updated successfully, but these errors were encountered: