Return 400 on invalid major-only HTTP version in Request-Line #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webknjaz
reviewed
Aug 12, 2019
webknjaz
reviewed
Aug 12, 2019
webknjaz
reviewed
Aug 12, 2019
| @@ -273,6 +273,10 @@ def test_content_length_required(test_client): | |||
| b'GET / HTTPS/1.1', # invalid proto | |||
| HTTP_BAD_REQUEST, b'Malformed Request-Line: bad protocol', | |||
| ), | |||
| ( | |||
| b'GET / HTTP/1', # invalid version | |||
There was a problem hiding this comment.
Ideas for extra PRs:
b'GET / HTTP/x'b'GET / HTTP/'b'GET / HTTP/\\0'b'GET / HTTP/☃'
webknjaz
changed the title
Codecov Report
@@ Coverage Diff @@
## master #219 +/- ##
==========================================
- Coverage 74.97% 74.28% -0.69%
==========================================
Files 23 23
Lines 3580 3582 +2
==========================================
- Hits 2684 2661 -23
- Misses 896 921 +25 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #219 +/- ##
==========================================
- Coverage 74.97% 74.28% -0.69%
==========================================
Files 23 23
Lines 3580 3582 +2
==========================================
- Hits 2684 2661 -23
- Misses 896 921 +25 |
|
Thanks @alpire! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❓ What kind of change does this PR introduce?
📋 What is the related issue number (starting with
#)Fixes #218
❓ What is the current behavior? (You can also link to an open issue here)
cherrypy returns a 500 on some malformed HTTP request due to a missing argument in a format string in
server.read_request_line.❓ What is the new behavior (if this is a feature change)?
The server now returns a 400.
📋 Checklist:
and description in grammatically correct, complete sentences
This change is