Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double newlines in log_error / log_info #8

Open
Jamie-Landeg-Jones opened this issue Jun 18, 2020 · 0 comments
Open

Double newlines in log_error / log_info #8

Jamie-Landeg-Jones opened this issue Jun 18, 2020 · 0 comments

Comments

@Jamie-Landeg-Jones
Copy link

Jamie-Landeg-Jones commented Jun 18, 2020

Hi. I've hacked modified libmaa maa/log.c up until now, but the latest update reminded me that I hadn't actually reported the issue. Oops. Sorry!

Basically, dictd terminates all strings in it's log_error / log_info calls with "\n".

The log_base_va function that is ultimately called in libmaa maa/log.c also terminates the received line with "\n", resulting in all logfile messages having an extra blank line after them.

I'm posting here, because I assume the format in libmaa is correct, but if you'd prefer to alter libmaa rather than dictd, that's obviously your call!

cheers, Jamie

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant