Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Twisted hook requirements #33

Closed
4 of 5 tasks
Tracked by #16
danuker opened this issue Feb 22, 2022 · 1 comment · Fixed by #43
Closed
4 of 5 tasks
Tracked by #16

Twisted hook requirements #33

danuker opened this issue Feb 22, 2022 · 1 comment · Fixed by #43
Assignees
@danuker

Comments

@danuker
Copy link
Contributor

danuker commented Feb 22, 2022 •
edited
Loading

For Twisted we need to support "needs-review" and "needs-changes" as non team members don't have access to the PR actions... they can only comment on a PR

and for Twisted and other open source projects in general, you have many PR from non-team members
@danuker danuker self-assigned this Feb 22, 2022
@danuker danuker changed the title Twisted requirements Twisted hook requirements Feb 22, 2022
@danuker danuker mentioned this issue Feb 22, 2022
Open
41 tasks
@danuker danuker mentioned this issue Mar 16, 2022
Open
This was referenced Jul 8, 2022
Merged
Closed
@adiroiban
Copy link
Member

For Twisted we need to support only "needs-review" and "needs-changes"

"changes-approved" and "needs-changes" should only be done via the GitHub UI by a "competent" user.

And the important part is to ask the review or (re)review from the fixed twisted/twisted-contributors team.

So for Twisted we have:

danuker added a commit that referenced this issue Oct 25, 2022
@danuker
[#33] Address Twisted needs (#43)
a9b8a78 
* Remove Twisted dependency.

* Split tests requiring GitHub.

* Add default reviewer for empty list.

* Fix test.

* WIP auto-request reviews, not just assign.

* WIP review request tests

* Allow skipping certain PRs.

* Use requested_reviewers everywhere.

* Add org-wide default reviewers.

* Add needs-review synonyms for Twisted.

* No longer mess with assignees.

* Rewrite RE_NEEDS_REVIEW as one regex.

* Support team review requests.

* Configure twisted-contributors as default reviewers for all Twisted repos.

* Fix deployment problems.

* Debug logging.

* Final small changes.

* Make commands case insensitive. Review can request review.

* Fix #46, expand tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danuker danuker

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#33] Address Twisted needs chevah/github-hooks-server
2 participants
@danuker @adiroiban