Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate off of Spectre CSS to another CSS framework #1694

Open
crismali opened this issue Oct 5, 2024 · 0 comments
Open

Migrate off of Spectre CSS to another CSS framework #1694

crismali opened this issue Oct 5, 2024 · 0 comments

Comments

@crismali
Copy link
Contributor

crismali commented Oct 5, 2024 •
edited
Loading

Why?

Spectre CSS has gone about 4 years without an update and CSS practices are changing, so we should find a solid, modern CSS approach and go with it.
@crismali crismali converted this from a draft issue Oct 5, 2024
@crismali crismali mentioned this issue Oct 5, 2024
Merged
jim pushed a commit that referenced this issue Oct 16, 2024
@crismali
Vendored spectre-css to update its scss syntax around colors and math (…
6da5b3b 
…#1695)

# What it does

This swaps out deprecated sass functions and syntax for their modern
counterparts.

# Why it is important

The times are a-changin' and so must we.

# UI Change Screenshot

An example of the deprecation message:
![Screenshot 2024-10-05 at 3 48
51 PM](https://github.com/user-attachments/assets/cc708920-95b4-4566-8140-0a6cdf321faf)

# Implementation notes

[Sass has a migration tool for these
changes](https://sass-lang.com/documentation/cli/migrator/) that I ran
on the affected files. The TL;DR of these changes is that `darken`,
`lighten`, and using `/` for division are all deprecated.

This PR looks super huge and it kind of is. Our primary css framework
(Spectre CSS) hasn't had an update in about 4 years and deprecation
warnings in the package were showing up in our build process. I copied
the main scss code from the repo into our `app/assets` and ran the
migration tool on those.

This is kind of a short term fix to get rid of some noise. Longer term,
we should migrate off of Spectre to something else ([I've added an issue
for
this](#1694)).
@phinze phinze mentioned this issue Nov 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Circulate Development
Status: No status
Milestone
No milestone
Development

No branches or pull requests
1 participant
@crismali