Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Rails 7 #975

Closed
jim opened this issue Feb 10, 2022 · 7 comments
Closed

Upgrade to Rails 7 #975

jim opened this issue Feb 10, 2022 · 7 comments
Assignees
Labels
📦 Dependency Update Updating one or more dependencies ruby Pull requests that update Ruby code

Comments

@jim
Copy link
Member

jim commented Feb 10, 2022

A new version of Rails is out! We'd like to upgrade to it this year now that things are looking pretty stable.

There is a guide to this process that we should be able to follow: https://guides.rubyonrails.org/upgrading_ruby_on_rails.html#upgrading-from-rails-6-1-to-rails-7-0

@jim jim added ruby Pull requests that update Ruby code 📦 Dependency Update Updating one or more dependencies labels Feb 10, 2022
@jim jim added this to the Dependency Updates milestone Mar 4, 2022
@archonic
Copy link
Contributor

Hi @jim, is this something I could take on? I also volunteer at a tool library and while we don't use circulate, I'm wondering if there's anything I could do to help out :)

@jim
Copy link
Member Author

jim commented Sep 25, 2023

@archonic Sure, if you want to take a stab at it, that would be great!

@jim jim moved this to 🏗 In progress in Circulate Development Sep 25, 2023
@archonic
Copy link
Contributor

Awesome! It looks like the Dockerfile hasn't been updated and seems to have a permissions error when starting. Do you mind if I bring that into a good state too?

@jim
Copy link
Member Author

jim commented Sep 27, 2023

@archonic Not at all - that would be great. I don't use it a ton myself, but I know that some folks do and having it fixed up would be appreciated.

I know in the past we used a wrapper script to workaround a permissions issue, perhaps that's not needed anymore?

@jim
Copy link
Member Author

jim commented Sep 28, 2023

I just merged #1134 in case if affects what you're working on 😄

@archonic
Copy link
Contributor

@jim All done! Lemme know if it needs any fixing up. I'll be away for a couple weeks after Oct 7th but available after that.

@jim jim assigned phinze and unassigned archonic Nov 7, 2023
@jim jim moved this from 🏗 In progress to ✅ Merged in Circulate Development Nov 27, 2023
@jim
Copy link
Member Author

jim commented Dec 1, 2023

Fixed by #1178.

@jim jim closed this as completed Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 Dependency Update Updating one or more dependencies ruby Pull requests that update Ruby code
Projects
Status: ✅ Merged
Development

Successfully merging a pull request may close this issue.

3 participants