Remove ImageKit #1164
Merged
Remove ImageKit #1164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the app to only rely on ActiveStorage and removes the third party dependency on ImageKit. Modern versions of Rails should be perfectly capable of serving thumbnails directly out of S3 without the help of a 3rd party service.
jim
approved these changes
Oct 28, 2023
|
Cool will leave it to you then. Feel free to give me a ping when you do and I'm happy to help test 🥼 |
|
Via Slack from @jim:
My research on this led me to a couple of findings:
Given that both a vips switch and a Rails upgrade are nontrivial next steps, and given that ImageKit was not actively harming anything, I'm proposing we revert this change for now to give us a chance to follow through with Rails upgrades and we revisit with an implementation of Named Variants w/ preprocessing once we're at 7.1. |
jim
pushed a commit
that referenced
this pull request
Oct 31, 2023
Reverts #1164 See #1164 (comment) for background.
phinze
added a commit
that referenced
this pull request
May 9, 2024
# What it does Configures ActiveStorage to use vips instead of imagemagick as its underlying image processor. Vips should use a lot less memory than imagemagick. See #1164 (comment) for more information and background. # Why it is important Currently an esoteric user traffic pattern has triggered ImageKit's throttling so images are broken on the site. # Implementation notes * My plan is to merge this, test it on staging, deploy it to production, and then remove IMAGEKIT_URL to see if the site works okay enough without any fancy variant preprocessing. The images will be a little slow on first load but I think this is better than no images! If it's super slow we can also run a loop in a rails console to manually preprocess all the existing items. * I'm not removing the IMAGEKIT_URL conditional yet which means we'll be able to quickly revert by restoring the environment variable. * My research suggests we can rely on the version of vips that comes preinstalled on Heroku rather than installing it ourselves. See Newlywords/heroku-buildpack-vips#36 for discussion. (There are some security implications of not being on the latest version, but we only have trusted users uploading images so I think we can afford to choose the simpler deployment option of using the existing package.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
This changes the app to only rely on ActiveStorage and removes the third party dependency on ImageKit.
Why it is important
Modern versions of Rails should be perfectly capable of serving thumbnails directly out of S3 without the help of a 3rd party service.
Resolves #1150
Implementation notes