Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser stalls on image mapping step towards end of largest bracket uploads as well as paging to Backs #218

Open
1 of 3 tasks
LennyEP opened this issue Feb 28, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@LennyEP
Copy link

LennyEP commented Feb 28, 2024

System

  • Windows 10 Pro 10.0.19045 Build 19045
  • V 4.4.1
  • Edge 122.0.2365.52 (Official build) (64-bit)

Affected Components

  • Backend
  • Frontend
  • Desktop Tool

Description

Whenever I try to complete an upload (610 cards, 452 images) to MPC for a XML file for an order of the largest bracket size (612), the MPC website stalls on image uploads to MPC starting around 70% complete. The image will upload to MPC correctly, but just after upload, the webpage and the tool stalls and doesn't complete the mapping step. The webpage will be dark grey as if it's buffering, and the tool will be stuck on 'uploading XX.png' even though the file has uploaded successfully.

I am able to get around it by refreshing the webpage, but the image doesn't successfully map to the card slot. Once I hit refresh every time it happens, and the upload process completes, I then go back and find the image in the MPC image selector and drag it to the correct card slot.

After doing this same upload a few times, it appears that the issue reproduced itself. it's unclear if the issue occured for specific images, or specific card slot numbers. It did happen twice where it was the same card slot number that didn't complete the mapping step.

The same stalling issue occurs after the fronts have been saved, and 'paging to backs' just sits in the buffering step on the website and the tool. After refreshing the webpage and manually moving ahead to the Backs page, and then going back to the tool to hit the 'try again' option, it works, and the back images upload and map correctly.

Combined order list_V3.zip

xml that was used for the upload is attached.

Steps to Reproduce

@ndepaola ndepaola added the bug Something isn't working label Feb 28, 2024
@ndepaola
Copy link
Collaborator

ndepaola commented Feb 28, 2024

howdy! the site stalling is a bug in MPC's frontend - in these instances, the tool is simply waiting for MPC to begin responding again. so not strictly a bug in the desktop tool. imo the project size or number of slots probably doesn't have much to do with it - i suspect this bug can occur on any image upload, but you're only encountering it on large orders because there are many more images to trigger the bug with. i'll investigate adding functionality to the tool for detecting these stalls and reloading + resuming the normal workflow.

@LennyEP
Copy link
Author

LennyEP commented Feb 29, 2024

Thanks for the reply. Does this bug apply across all browsers?

I really love the tool BTW, great work.

@ndepaola
Copy link
Collaborator

ndepaola commented Mar 2, 2024

i haven't paid any attention to whether it applies across browsers but my expectation is that it would.

thanks for the positive feedback! <3 i'm glad it's bringing you joy

@Apito
Copy link

Apito commented Mar 13, 2024

I've also been having this issue. For me it's stalling as it switches to upload the backs. I've tried across Edge and Chrome, It stalls even sooner on edge. The project size I'm uploading is 198 cards.

@ndepaola
Copy link
Collaborator

ndepaola commented Aug 6, 2024

howdy - i've just cut a new release https://github.com/chilli-axe/mpc-autofill/releases/tag/v4.5.2 could you try this version and see if your issue is resolved?

i've strengthened our logic which waits for the MPC frontend to respond a bit - it should now identify these cases and refresh the page where necessary (and if it was partway through inserting an image into a slot, it'll retry that)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Development

No branches or pull requests

3 participants