Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images don't really reference anything #13

Open
Timendus opened this issue May 21, 2023 · 2 comments
Open

Images don't really reference anything #13

Timendus opened this issue May 21, 2023 · 2 comments

Comments

@Timendus
Copy link
Collaborator

We have a property images now (on both programs and ROMs), which we use to store filenames of images that presumably show the gameplay. The issue, as I see it, is that we don't store those images in this database yet. So the filenames don't really reference anything that people can use.

Two solutions:

  1. Remove the properties
  2. Add the images

I'm in favour of the second. I propose we add a directory images to the project's root. In it we add all images using a SHA1 hash over their contents as the filename (but with the original extension of course). Then we reference those new filenames in the images properties.

Unless we wish to preserve the original image filenames for some reason..? I can't really think of one.

@Timendus
Copy link
Collaborator Author

Another solution could be to make the images property reference URLs of images, referring to places elsewhere on the internet. This would probably work fine for the CHIP-8 Archive and some other long lived sites, but we'd have to keep track of broken links and remove those. That doesn't feel very self-contained or future proof...

@pyrsmk
Copy link

pyrsmk commented Feb 20, 2024

I'm for the second solution, keeping the images in the database to keep consistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants