Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: remove file property from ROMs #14

Open
Timendus opened this issue May 21, 2023 · 4 comments
Open

Proposal: remove file property from ROMs #14

Timendus opened this issue May 21, 2023 · 4 comments

Comments

@Timendus
Copy link
Collaborator

The same ROMs are shared under lots of different filenames. Which is precisely the reason why we use SHA1 hashes for this database. We currently have a property file for each ROM, which contains the filename of the ROM as we first encountered it. However, this filename has no particular value. If people try to match ROMs on filename, that will only lead to issues.

So I suggest we just remove it.

@pyrsmk
Copy link

pyrsmk commented Feb 20, 2024

I'm 100% for removal. The property does not add anything and it makes no sense to use it.

@tobiasvl
Copy link
Member

I think it holds some value - the filename is the only human-readable metadata associated with CHIP-8 games. If you find a reference list of CHIP-8 ROM filenames somewhere (an old website, a computer magazine from the 70s, etc) where you can't download/transcribe the ROM, the filename is the only identifier. I agree that it's fairly useless for machines (or humans who can run a SHA1 check), but perhaps it could be made into an optional array of filenames instead?

@pyrsmk
Copy link

pyrsmk commented Feb 20, 2024

In fact, it seems to me that this is out of the scope of the project, aiming to have a reliable database of CHIP-8 ROMs metadata, usable by other projects (like interpreters).

If you need to find something by hand, you have all the needed metadata, in a usable format, in the other fields. You just have to search for the name in the list (or anything else) and find the closest item that matches what you have.

Also, filenames are inconsistent by nature. You cannot maintain an array because it is theoretically infinite.

But, on the other hand, it would really make sense to have an array of the available extensions for that ROM.

@Timendus
Copy link
Collaborator Author

I think changing the property to an array would also be fine. I agree that it MAY sometimes hold a tiny bit of value. Also, I'm a digital hoarder and I don't like losing information 😉

I would argue for something that allows for a bit more "vagueness" than file then, like sometimesCalled, maybe?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants