i3c: Start basic driver #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does the initialization sequence, routes interrupts, and does passes reads and writes to the clients. I haven't had a chance to do much testing yet, but that will be easier once the peripheral is more complete.
swenson
requested review from
parvathib,
mlvisaya,
mhatrevi,
vsonims and
helloxiling
parvathib
requested changes
Nov 26, 2024
runtime/i3c/src/hil.rs
Outdated
| fn disable(&self); | ||
|
|
||
| /// Get the maximum transmission unit (MTU) size. | ||
| fn get_mtu_size(&self) -> usize; |
There was a problem hiding this comment.
I think MTU would not be an appropriate term for the I3C target device (sorry for misleading). Instead, we should provide an interface that gives that following device information:
dynamic_addr: u8
max_read_len: u16
max_write_len: u16
a possible interface could be:
fn get_device_info(&self) -> I3CTargetInfo
runtime/i3c/src/core.rs
Outdated
| } | ||
|
|
||
| fn get_mtu_size(&self) -> usize { | ||
| 250 |
There was a problem hiding this comment.
we should define a constant that specifies the maximum size for the read/write lengths that the I3C target can receive. This is needed to allocate static Tx and Rx packet buffers for the MCTP stack
parvathib
approved these changes
Nov 26, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does the initialization sequence, routes interrupts, and does passes reads and writes to the clients.
I haven't had a chance to do much testing yet, but that will be easier once the peripheral is more complete.