Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Probes to .toString Data methods (backport #4478) #4480

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Add Probes to .toString Data methods (backport #4478) #4480

merged 1 commit into from
Nov 26, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 18, 2024

Contributor Checklist

  • [N/A] Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • [N/A] Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Bugfix

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference).

Release Notes

Probe chisel types now include the kind of probe and layer in their .toString method

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.
This is an automatic backport of pull request #4478 done by [Mergify](https://mergify.com).

@mergify mergify bot added Backport Automated backport, please consider for minor release bp-conflict labels Oct 18, 2024
@mergify Mergify
Copy link
Contributor Author

mergify bot commented Oct 18, 2024

Cherry-pick of 8c718b2 has failed:

On branch mergify/bp/6.x/pr-4478
Your branch is up to date with 'origin/6.x'.

You are currently cherry-picking commit 8c718b2b6.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   src/test/scala/chiselTests/DataPrint.scala

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   core/src/main/scala/chisel3/Data.scala
	both modified:   src/test/scala/chisel3/TypeEquivalenceSpec.scala
	both modified:   src/test/scala/chiselTests/LayerSpec.scala
	both modified:   src/test/scala/chiselTests/ProbeSpec.scala

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@github-actions github-actions bot added the Bugfix Fixes a bug, will be included in release notes label Oct 18, 2024
@azidar @jackkoenig
Add Probes to .toString Data methods (#4478)
02bf29a 
* Add probe string to .toString Data methods

* Update chisel tests with new probe toString

(cherry picked from commit 8c718b2)
@chiselbot chiselbot merged commit b84d108 into 6.x Nov 26, 2024
15 checks passed
@chiselbot chiselbot deleted the mergify/bp/6.x/pr-4478 branch November 26, 2024 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Backport Automated backport, please consider for minor release Bugfix Fixes a bug, will be included in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jackkoenig @chiselbot @azidar