Move default interaction to selector.

Author: chmac

app/src/scenes/Combos/combos.reducer.js

@@ -120,13 +120,19 @@ export const getComboCount = (state: State) => {
   return (count * (count - 1)) / 2;
 };
 
+const defaultInteraction = {
+  interaction: "unknown",
+  status: "unknown",
+  description: "",
+};
+
 export const getInteraction = (ids: string[]): Interaction => {
   return (
     find((interaction: Interaction) => {
       // If the difference between this substance's IDs array and our target IDs
       // array is empty, then this interaction is a match.
       return isEmpty(difference(interaction.ids, ids));
-    })(interactions) || {}
+    })(interactions) || defaultInteraction
   );
 };
 

app/src/scenes/Combos/components/Combo.component.js

@@ -22,17 +22,8 @@ type Props = {
   secondId: string,
 } & StateProps;
 
-const defaultInteraction = {
-  interaction: "unknown",
-  status: "unknown",
-  description: "",
-};
-
 const Combo = (props: Props) => {
-  const { first, second } = props;
-  const interaction = isEmpty(props.interaction)
-    ? defaultInteraction
-    : props.interaction;
+  const { first, second, interaction } = props;
 
   return (
     <div>