Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(maint) Add spell check listing to repository #855

Closed
wants to merge 0 commits into from

Conversation

AdmiringWorm
Copy link
Member

Description Of Changes

This PR adds two new workflows that uses misspell and LanguageTool
to run verification on the changed text in a PR, or the entire repository
on demand to verify that there are no spelling mistakes and that sentences
are correct.

Motivation and Context

We should strive to not have spelling mistakes when merging PR's into the repository.

Testing

Workflows tested through my own fork

Operating Systems Testing

N/A

Change Types Made

  • Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.
  • Build related

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v2 compatibility checked?

Related Issue

N/A

@AdmiringWorm AdmiringWorm self-assigned this Oct 4, 2023
@AdmiringWorm AdmiringWorm requested review from gep13 and pauby October 4, 2023 13:04
@AdmiringWorm AdmiringWorm marked this pull request as draft October 4, 2023 13:16
@AdmiringWorm
Copy link
Member Author

Converted this to draft as it seems some of our files are too long to be usable with the LanguageTool action (at least without change).

@@ -85,7 +85,7 @@ You will also need to have at least one Group of computers already defined.
By default, if any Deployment Step fails, the overall Deployment is marked as Failed.
* `Only run other Deployment Steps if successful`.
Enabling this option will prevent subsequent Deployment Steps from starting if this step fails.
The overall Deployment will be marked as Failed, and subsequent steps will be Cancelled.
The overall Deployment will be marked as Failed, and subsequent steps will be Canceled.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use Cancelled everywhere in the CCM application, so I don't think we can continue with this suggestion. I remember a discussion at the time about what should be used, as it wasn't immediately clear what was the right answer, and we settled on Cancelled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants