Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for MonteCarloAnisotropicBarostat? #349

Open
jchodera opened this issue Apr 19, 2018 · 3 comments
Open

Support for MonteCarloAnisotropicBarostat? #349

jchodera opened this issue Apr 19, 2018 · 3 comments

Comments

@jchodera
Copy link
Member

How would we add support to ThermodynamicState for MonteCarloAnisotropicBarostat? Can we just detect whether pressure is a scalar or vector, and handle the barostat appropriately?

@andrrizzi
Copy link
Contributor

Yes, I think that would work.

@Olllom
Copy link
Contributor

Olllom commented Oct 30, 2019

cross-referencing #437, where support for the MonteCarloMembraneBarostat and MonteCarloAnisotropicBarostat was added.

The membrane barostat is fully supported and lateral pressure can be controlled independently via the surface tension.

The anisotropic barostat is only supported if the pressure in all directions is the same. This covers the most common use case, where certain axes of the box are fixed.

I did not code up full anisotropic support for three reasons:

  1. what would anybody use this for?
  2. it adds significant complexity to the ThermodynamicState
  3. not sure how the reduced potential would look like for anisotropic pressure.

@mrshirts
Copy link

mrshirts commented Oct 30, 2019

not sure how the reduced potential would look like for anisotropic pressure.

This is something we are currently working on for GROMACS, but it may be a month or two before we've tested things and can share.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants