From 4eb570a99b59314ba704b5b3eaa91b25ea30bbf6 Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Fri, 7 Oct 2022 21:11:57 +0000 Subject: [PATCH] Adding tarfile member sanitization to extractall() --- cleanir/tools/get_dataset.py | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/cleanir/tools/get_dataset.py b/cleanir/tools/get_dataset.py index b024d5e..98a42aa 100644 --- a/cleanir/tools/get_dataset.py +++ b/cleanir/tools/get_dataset.py @@ -83,7 +83,26 @@ def download_lfw(dst_path): download_from_url(label_url, label_path) download_from_url(data_url, data_path) with tarfile.open(data_path, 'r') as tar_obj: - tar_obj.extractall(dst_path) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tar_obj, dst_path) os.remove(data_path) except OSError as error: