Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable to launch with ros 2 #19

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Enable to launch with ros 2 #19

merged 1 commit into from
Mar 13, 2024

Conversation

ssr-yuki
Copy link
Member

Please check that this PR allows us to launch Choreonoid on ROS 2 with the following command:

ros2 launch choreonoid_ros choreonoid.launch.xml

@ssr-yuki
Enable to launch with ros 2
70d8d65 
- add and install a launch file
- remove ros-dependent argv-s generated by the ros 2 launch system
@ssr-yuki ssr-yuki requested a review from HansRobo March 12, 2024 15:03
@ssr-yuki ssr-yuki self-assigned this Mar 12, 2024
HansRobo
HansRobo approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@HansRobo HansRobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I executed the command below and it works correctly!

ros2 launch choreonoid_ros choreonoid.launch.xml choreonoid_arg:='<path/to/project.cnoid>'

@HansRobo HansRobo merged commit b52bdf0 into master Mar 13, 2024
1 check passed
@ssr-yuki ssr-yuki deleted the ros2-launch branch March 17, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HansRobo HansRobo HansRobo approved these changes

Assignees

@ssr-yuki ssr-yuki

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ssr-yuki @HansRobo