Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix installation conditions of 'launch' files with catkin #23

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

ssr-yuki
Copy link
Member

@ssr-yuki ssr-yuki commented May 1, 2024

This PR resolves #22 .

To guarantee the requirements discussed in #16 , this PR adds an additional condition to install the launch directory: choreonoid_ros installs the directory only if the destination path ends with install, such as ~/catkin_ws/install.

In fact, this is an ad hoc bug fix, but I don't have any other ideas at the moment.

FYI: the following document provides the list of variables we can utilise in CMake:
http://docs.ros.org/en/melodic/api/catkin/html/user_guide/variables.html

@ssr-yuki ssr-yuki added the bug Something isn't working label May 1, 2024
@ssr-yuki ssr-yuki requested a review from HansRobo May 1, 2024 17:51
@ssr-yuki ssr-yuki self-assigned this May 1, 2024
@ssr-yuki
Copy link
Member Author

ssr-yuki commented May 1, 2024

@YoheiKakiuchi Could you check if this PR affects your software please?
All suggestions are welcome.

@HansRobo HansRobo marked this pull request as ready for review May 9, 2024 23:14
@HansRobo
Copy link
Member

HansRobo commented May 9, 2024

I made this PR ready for review, with @ssr-yuki 's consent in another chat tool.

Copy link
Member

@HansRobo HansRobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I confirmed that this works properly in my machine.

@s-nakaoka s-nakaoka merged commit c36cb7b into master Oct 9, 2024
1 check passed
@ssr-yuki ssr-yuki deleted the fix-launch-dir-installation branch October 10, 2024 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

launchファイルの重複エラーについて
3 participants