From 0baa2c10ddd66e48f0d5f9fba1ae5e4fafcf6547 Mon Sep 17 00:00:00 2001 From: Melissa Greenbaum <69476188+magreenbaum@users.noreply.github.com> Date: Sat, 10 Dec 2022 09:31:50 -0500 Subject: [PATCH] fix: Update `role_name` default to `null` (#319) Co-authored-by: magreenbaum --- examples/iam-assumable-role/main.tf | 2 +- modules/iam-assumable-role/README.md | 2 +- modules/iam-assumable-role/variables.tf | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/examples/iam-assumable-role/main.tf b/examples/iam-assumable-role/main.tf index f94a9afb..41f90f0b 100644 --- a/examples/iam-assumable-role/main.tf +++ b/examples/iam-assumable-role/main.tf @@ -49,7 +49,7 @@ module "iam_assumable_role_custom" { create_role = true - role_name = "custom" + role_name_prefix = "custom-" role_requires_mfa = false role_sts_externalid = "some-id-goes-here" diff --git a/modules/iam-assumable-role/README.md b/modules/iam-assumable-role/README.md index 3408ccd3..3e7ec50a 100644 --- a/modules/iam-assumable-role/README.md +++ b/modules/iam-assumable-role/README.md @@ -57,7 +57,7 @@ No modules. | [poweruser\_role\_policy\_arn](#input\_poweruser\_role\_policy\_arn) | Policy ARN to use for poweruser role | `string` | `"arn:aws:iam::aws:policy/PowerUserAccess"` | no | | [readonly\_role\_policy\_arn](#input\_readonly\_role\_policy\_arn) | Policy ARN to use for readonly role | `string` | `"arn:aws:iam::aws:policy/ReadOnlyAccess"` | no | | [role\_description](#input\_role\_description) | IAM Role description | `string` | `""` | no | -| [role\_name](#input\_role\_name) | IAM role name | `string` | `""` | no | +| [role\_name](#input\_role\_name) | IAM role name | `string` | `null` | no | | [role\_name\_prefix](#input\_role\_name\_prefix) | IAM role name prefix | `string` | `null` | no | | [role\_path](#input\_role\_path) | Path of IAM role | `string` | `"/"` | no | | [role\_permissions\_boundary\_arn](#input\_role\_permissions\_boundary\_arn) | Permissions boundary ARN to use for IAM role | `string` | `""` | no | diff --git a/modules/iam-assumable-role/variables.tf b/modules/iam-assumable-role/variables.tf index 3d096abf..2f411404 100644 --- a/modules/iam-assumable-role/variables.tf +++ b/modules/iam-assumable-role/variables.tf @@ -43,7 +43,7 @@ variable "create_instance_profile" { variable "role_name" { description = "IAM role name" type = string - default = "" + default = null } variable "role_name_prefix" {