We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hi! 👋
Firstly, thanks for your work on this project! 🙂
Today I used patch-package to patch [email protected] for the project I'm working on.
[email protected]
When nesting SkeletonPlaceholder.Item typescript errors occur as there is not children prop.
Here is the diff that solved my problem:
diff --git a/node_modules/react-native-skeleton-placeholder/lib/skeleton-placeholder.d.ts b/node_modules/react-native-skeleton-placeholder/lib/skeleton-placeholder.d.ts index 58cfac7..7c8fc8d 100644 --- a/node_modules/react-native-skeleton-placeholder/lib/skeleton-placeholder.d.ts +++ b/node_modules/react-native-skeleton-placeholder/lib/skeleton-placeholder.d.ts @@ -33,6 +33,7 @@ declare type SkeletonPlaceholderProps = { }; declare type SkeletonPlaceholderItemProps = ViewStyle & { style?: StyleProp<ViewStyle>; + children?: JSX.Element[] | JSX.Element; }; declare const SkeletonPlaceholder: React.FC<SkeletonPlaceholderProps> & { Item: React.FC<SkeletonPlaceholderItemProps>;
This issue body was partially generated by patch-package.
The text was updated successfully, but these errors were encountered:
This was required for me (parent placeholder element can take multiple children)
diff --git a/node_modules/react-native-skeleton-placeholder/lib/skeleton-placeholder.d.ts b/node_modules/react-native-skeleton-placeholder/lib/skeleton-placeholder.d.ts index 58cfac7..0fb7755 100644 --- a/node_modules/react-native-skeleton-placeholder/lib/skeleton-placeholder.d.ts +++ b/node_modules/react-native-skeleton-placeholder/lib/skeleton-placeholder.d.ts @@ -4,7 +4,7 @@ declare type SkeletonPlaceholderProps = { /** * Determines component's children. */ - children: JSX.Element; + children: JSX.Element[] | JSX.Element; /** * Determines the color of placeholder. */ @@ -33,6 +33,7 @@ declare type SkeletonPlaceholderProps = { }; declare type SkeletonPlaceholderItemProps = ViewStyle & { style?: StyleProp<ViewStyle>; + children?: JSX.Element[] | JSX.Element; }; declare const SkeletonPlaceholder: React.FC<SkeletonPlaceholderProps> & { Item: React.FC<SkeletonPlaceholderItemProps>;
Sorry, something went wrong.
Same for me. Can somebody create PR for this bug?
I appreciate if somebody create a PR
#109
No branches or pull requests
Hi! 👋
Firstly, thanks for your work on this project! 🙂
Today I used patch-package to patch
[email protected]
for the project I'm working on.When nesting SkeletonPlaceholder.Item typescript errors occur as there is not children prop.
Here is the diff that solved my problem:
This issue body was partially generated by patch-package.
The text was updated successfully, but these errors were encountered: