Skip to content

Commit

Permalink
content [nfc]: Comment about not setting Heading weight relative to c…
Browse files Browse the repository at this point in the history
…ontext
  • Loading branch information
chrisbobbe committed Jun 5, 2024
1 parent 6d246ae commit 1531b9e
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions lib/widgets/content.dart
Original file line number Diff line number Diff line change
Expand Up @@ -252,6 +252,11 @@ class Heading extends StatelessWidget {
fontSize: kBaseFontSize * emHeight,
height: 1.4,
)
// Could set boldness relative to ambient text style, which itself
// might be bolder than normal (e.g. in spoiler headers).
// But this didn't seem like a clear improvement and would make inline
// **bold** spans less distinct; discussion:
// https://github.com/zulip/zulip-flutter/pull/706#issuecomment-2141326257
.merge(weightVariableTextStyle(context, wght: 600)),
node: node));
}
Expand Down

0 comments on commit 1531b9e

Please sign in to comment.