Skip to content

Commit

Permalink
msglist: Tweak app-bar title to look better after recent text-size ch…
Browse files Browse the repository at this point in the history
…ange

In a recent commit in this series, we decreased the app-bar title
text size, to align with the new Figma.

The spacing and alignment in MessageListAppBarTitle for stream and
topic narrows looked a little off after doing that. This should make
it look better. I'm leaving the comment saying it's "a bit ad hoc",
though; this will remain true until we have a Figma design to
follow.
  • Loading branch information
chrisbobbe committed Jun 17, 2024
1 parent 1252915 commit 3a7ddc3
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions lib/widgets/message_list.dart
Original file line number Diff line number Diff line change
Expand Up @@ -131,11 +131,10 @@ class MessageListAppBarTitle extends StatelessWidget {
// TODO(design): The vertical alignment of the stream privacy icon is a bit ad hoc.
// For screenshots of some experiments, see:
// https://github.com/zulip/zulip-flutter/pull/219#discussion_r1281024746
crossAxisAlignment: CrossAxisAlignment.baseline,
textBaseline: localizedTextBaseline(context),
crossAxisAlignment: CrossAxisAlignment.center,
children: [
Icon(size: 16, icon),
const SizedBox(width: 8),
const SizedBox(width: 4),
Flexible(child: Text(text)),
]);
}
Expand Down

0 comments on commit 3a7ddc3

Please sign in to comment.