Fixed pagination in addressbook and save new contacts #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a bug in rcube_db::num_rows when used on a limitquery the query has a record offset. fix: removed all references to deprecated rcube_db::num_rows replaced with db count where count is required (also less expensive). removed counting where not required
Fix: calling carddav_addressbook_sync with null instead of false for card_id prevents the sync to try an update on nonexisting card_id false.
functions found: - get_table_name - write_log
removed ORDER BY for count(*) query which caused an error
fmbiete
added a commit
to fmbiete/Roundcube-CardDAV
that referenced
this pull request
Aug 28, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this fixes the following issues:
Tested with roundcube 1.0.1, mysql backend and owncloud 6.0.3.