initialise the process environment only once

christian-rauch · Jul 16, 2024 · 2c0c8e3 · 2c0c8e3
1 parent a1a8d95
commit 2c0c8e3
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/src/project_manager/ros_utils.cpp b/src/project_manager/ros_utils.cpp
@@ -317,7 +317,7 @@ QList<Utils::FilePath> ROSUtils::installedDistributions()
 
 void ROSUtils::sourceWorkspaceHelper(QProcess *process, const QString &path)
 {
-  QProcessEnvironment env = QProcessEnvironment::systemEnvironment();
+  QProcessEnvironment env;
 
   if (!path.isEmpty())
   {
@@ -1211,6 +1211,8 @@ QProcessEnvironment ROSUtils::getWorkspaceEnvironment(const WorkspaceInfo &works
 {
     QProcess process;
 
+    // initialise environment
+    process.setProcessEnvironment(QProcessEnvironment::systemEnvironment());
     process.setProcessEnvironment(current_environment.toProcessEnvironment());
 
     sourceWorkspace(&process, workspaceInfo);