Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orientation difference between pnp and homography #37

Closed
eliasdc opened this issue Jun 27, 2024 · 2 comments · Fixed by #38
Closed

Orientation difference between pnp and homography #37

eliasdc opened this issue Jun 27, 2024 · 2 comments · Fixed by #38

Comments

@eliasdc
Copy link

eliasdc commented Jun 27, 2024

The pose estimations have a different resulting frame.

  • homography: z points inwards into the tag
  • pnp: z points out of the tag

Ideally add a parameter to request which is preferred (in or out) than people can adopt between each. or include a rotation parameter.

@christianrauch
Copy link
Owner

I can reproduce this and am surprised that this wasn't caught in the discussions in #14. The z-axis of the tag frame is supposed to point away from the tag towards the camera (a.k.a. "outwards") as it is with the pnp option, which has been adapted from the ROS 1 node. See the second half of #14 (comment) for an explanation of the tag frame orientation.

The homography option should produce the same tag frame orientation. IMHO, adding another option for the preferred tag orientation is not so useful as users can always apply additional transformations on top to achieve their desired tag orientation.

@christianrauch
Copy link
Owner

Does #38 fix your issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants