From d66dee9f8a206710352f0fea762b929ff76a287a Mon Sep 17 00:00:00 2001 From: Cody Kaup Date: Fri, 1 Nov 2024 12:05:55 -0500 Subject: [PATCH] Fix diagnostic flag parsing --- node-src/lib/getOptions.test.ts | 6 ++++++ node-src/lib/getOptions.ts | 6 ++---- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/node-src/lib/getOptions.test.ts b/node-src/lib/getOptions.test.ts index 1421544ea..a0c63869b 100644 --- a/node-src/lib/getOptions.test.ts +++ b/node-src/lib/getOptions.test.ts @@ -209,4 +209,10 @@ describe('getOptions', () => { uploadMetadata: true, }); }); + + it('allows you to specify a diagnostics file name', async () => { + expect(getOptions(getContext(['--diagnostics-file', 'output.json']))).toMatchObject({ + diagnosticsFile: 'output.json', + }); + }); }); diff --git a/node-src/lib/getOptions.ts b/node-src/lib/getOptions.ts index 947556fa0..c9dccf00b 100644 --- a/node-src/lib/getOptions.ts +++ b/node-src/lib/getOptions.ts @@ -141,11 +141,9 @@ export default function getOptions(ctx: InitialContext): Options { forceRebuild: trueIfSet(flags.forceRebuild), debug: flags.debug, diagnosticsFile: - defaultIfSet(flags.diagnosticsFile, DEFAULT_DIAGNOSTICS_FILE) || + defaultUnlessSetOrFalse(flags.diagnosticsFile, DEFAULT_DIAGNOSTICS_FILE) || // for backwards compatibility - flags.diagnostics - ? DEFAULT_DIAGNOSTICS_FILE - : undefined, + (flags.diagnostics ? DEFAULT_DIAGNOSTICS_FILE : undefined), junitReport: defaultIfSet(flags.junitReport, DEFAULT_REPORT_FILE), zip: flags.zip, skipUpdateCheck: flags.skipUpdateCheck,