Merge pull request #24 from chrometoasters/minor/clean-codebase

Clean codebase
chrometoasters · May 5, 2020 · 5a24e84 · 5a24e84
2 parents fd1dd87 + 877a72a
commit 5a24e84
Show file tree

Hide file tree

Showing 6 changed files with 2 additions and 18 deletions.
diff --git a/src/Extensions/DataObjectTaxonomiesDataExtension.php b/src/Extensions/DataObjectTaxonomiesDataExtension.php
@@ -8,18 +8,11 @@
 use Chrometoaster\AdvancedTaxonomies\Validators\TaxonomyRulesValidator;
 use SilverStripe\Forms\FieldList;
 use SilverStripe\Forms\GridField\GridField;
-use SilverStripe\Forms\GridField\GridFieldAddExistingAutocompleter;
-use SilverStripe\Forms\GridField\GridFieldAddNewButton;
-use SilverStripe\Forms\GridField\GridFieldConfig_RelationEditor;
-use SilverStripe\Forms\GridField\GridFieldDataColumns;
-use SilverStripe\Forms\GridField\GridFieldEditButton;
-use SilverStripe\Forms\GridField\GridFieldFilterHeader;
 use SilverStripe\Forms\LiteralField;
 use SilverStripe\ORM\DataExtension;
 use SilverStripe\ORM\DataList;
 use SilverStripe\ORM\FieldType\DBField;
 use SilverStripe\ORM\FieldType\DBHTMLText;
-use SilverStripe\Versioned\GridFieldArchiveAction;
 
 /**
  * Class DataObjectTaxonomiesDataExtension
@@ -70,7 +63,7 @@ public function updateCMSFields(FieldList $fields)
 
         $gridFieldConfig = FieldsProvider::getTaggingGridFieldConfig(
             $searchList,
-            ['getAllRequiredTypesNames'  => 'Requires']
+            ['getAllRequiredTypesNames' => 'Requires']
         );
 
         $fields->findOrMakeTab('Root.Tags', _t(self::class . '.TagsTabTitle', 'Tags'));

diff --git a/src/Extensions/FileFormFactoryTaxonomyExtension.php b/src/Extensions/FileFormFactoryTaxonomyExtension.php
@@ -38,9 +38,6 @@ public function updateFormFields(FieldList $fields, $controller, $formName, $con
             $record = $context['Record'];
 
             if (!is_a($record, Folder::class)) {
-                if ($formName === 'fileEditForm') {
-                }
-
                 $tags = TreeMultiselectField::create(
                     'Tags',
                     _t(self::class . '.Tags', 'Tags'),

diff --git a/src/Forms/FieldsProvider.php b/src/Forms/FieldsProvider.php
@@ -3,9 +3,6 @@
 namespace Chrometoaster\AdvancedTaxonomies\Forms;
 
 use Chrometoaster\AdvancedTaxonomies\Models\TaxonomyTerm;
-use Chrometoaster\AdvancedTaxonomies\Forms\GridFieldAddTagsAutocompleter;
-use Chrometoaster\AdvancedTaxonomies\Forms\GridFieldInfoLink;
-use Chrometoaster\AdvancedTaxonomies\Forms\GridFieldOrderableRows;
 use SilverStripe\Forms\GridField\GridFieldAddExistingAutocompleter;
 use SilverStripe\Forms\GridField\GridFieldAddNewButton;
 use SilverStripe\Forms\GridField\GridFieldConfig;

diff --git a/src/Models/TaxonomyTerm.php b/src/Models/TaxonomyTerm.php
@@ -36,8 +36,8 @@
 use SilverStripe\Security\Permission;
 use SilverStripe\Security\PermissionProvider;
 use SilverStripe\Versioned\GridFieldArchiveAction;
-use SilverStripe\View\ViewableData;
 use SilverStripe\View\ArrayData;
+use SilverStripe\View\ViewableData;
 use UndefinedOffset\SortableGridField\Forms\GridFieldSortableRows;
 
 /**

diff --git a/src/Tasks/RemoveOrphanedTagRelationObjectsTask.php b/src/Tasks/RemoveOrphanedTagRelationObjectsTask.php
@@ -8,7 +8,6 @@
 use SilverStripe\Control\HTTPRequest;
 use SilverStripe\Core\ClassInfo;
 use SilverStripe\Dev\BuildTask;
-use SilverStripe\Dev\Deprecation;
 use SilverStripe\ORM\DataObject;
 use SilverStripe\ORM\DataObjectSchema;
 use SilverStripe\ORM\DB;

diff --git a/tests/TaxonomyTermTest.php b/tests/TaxonomyTermTest.php
@@ -6,7 +6,6 @@
 use Chrometoaster\AdvancedTaxonomies\Tests\Models\OwnerObject;
 use Chrometoaster\AdvancedTaxonomies\Validators\TaxonomyRulesValidator;
 use SilverStripe\Dev\SapphireTest;
-use SilverStripe\ORM\ManyManyThroughList;
 use SilverStripe\ORM\ValidationException;
 use SilverStripe\Versioned\Versioned;
 
@@ -587,5 +586,4 @@ public function testTaggedObjectsCollectionMechanism()
             'tagForTaggedObjects should show one tagged objects after a tag removal'
         );
     }
-
 }