Skip to content

Commit

Permalink
Replace a workaround class GridFieldOrderableRow with its origin class
Browse files Browse the repository at this point in the history
The issue tackled in the workaround class is fixed
in its origin module `symbiote/silverstripe-gridfieldextensions`
at its release v3.2.3, so we remove the temporary
workaround, and use its original class in the module
by adding the required version to composer.json
  • Loading branch information
normann committed Jul 30, 2020
1 parent 5a24e84 commit bdf5520
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 103 deletions.
3 changes: 2 additions & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@
"require": {
"silverstripe/admin": "^1",
"silverstripe/framework": "^4",
"silverstripe/vendor-plugin": "^1"
"silverstripe/vendor-plugin": "^1",
"symbiote/silverstripe-gridfieldextensions": "^3.2.3"
},
"extra": {
"expose": [
Expand Down
1 change: 1 addition & 0 deletions src/Forms/FieldsProvider.php
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
use SilverStripe\Forms\GridField\GridFieldFilterHeader;
use SilverStripe\ORM\DataList;
use SilverStripe\Versioned\GridFieldArchiveAction;
use Symbiote\GridFieldExtensions\GridFieldOrderableRows;

/**
* Class FieldsProvider
Expand Down
100 changes: 0 additions & 100 deletions src/Forms/GridFieldOrderableRows.php

This file was deleted.

2 changes: 1 addition & 1 deletion src/ModelAdmins/TaxonomyModelAdmin.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@

namespace Chrometoaster\AdvancedTaxonomies\ModelAdmins;

use Chrometoaster\AdvancedTaxonomies\Forms\GridFieldOrderableRows;
use Chrometoaster\AdvancedTaxonomies\Models\TaxonomyTerm;
use SilverStripe\Admin\ModelAdmin;
use SilverStripe\Forms\GridField\GridField;
use SilverStripe\Forms\GridField\GridFieldAddNewButton;
use SilverStripe\ORM\SS_List;
use SilverStripe\View\Requirements;
use Symbiote\GridFieldExtensions\GridFieldOrderableRows;
use UndefinedOffset\SortableGridField\Forms\GridFieldSortableRows;

/**
Expand Down
2 changes: 1 addition & 1 deletion src/Models/TaxonomyTerm.php
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
namespace Chrometoaster\AdvancedTaxonomies\Models;

use Chrometoaster\AdvancedTaxonomies\Forms\GridFieldAddTagsAutocompleter;
use Chrometoaster\AdvancedTaxonomies\Forms\GridFieldOrderableRows;
use Chrometoaster\AdvancedTaxonomies\Generators\PluralGenerator;
use Chrometoaster\AdvancedTaxonomies\Generators\URLSegmentGenerator;
use Chrometoaster\AdvancedTaxonomies\ModelAdmins\TaxonomyModelAdmin;
Expand Down Expand Up @@ -38,6 +37,7 @@
use SilverStripe\Versioned\GridFieldArchiveAction;
use SilverStripe\View\ArrayData;
use SilverStripe\View\ViewableData;
use Symbiote\GridFieldExtensions\GridFieldOrderableRows;
use UndefinedOffset\SortableGridField\Forms\GridFieldSortableRows;

/**
Expand Down

0 comments on commit bdf5520

Please sign in to comment.