Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestion: Implement convenience methods from NaiveWeek on IsoWeek #1612

Open
and-reas-se opened this issue Sep 11, 2024 · 1 comment
Open

Suggestion: Implement convenience methods from NaiveWeek on IsoWeek #1612

and-reas-se opened this issue Sep 11, 2024 · 1 comment

Comments

@and-reas-se
Copy link

and-reas-se commented Sep 11, 2024 •
edited
Loading

Hi,

NaiveWeek has the convenience methods first_day, last_day and days. But these are not implemented on IsoWeek. There is a previous issue #654 that proposed adding these to IsoWeek, but the PR (#666) that closed that issue as completed did not implement these methods on IsoWeek. Was this an oversight?

Either way, having these methods on IsoWeek as well would be useful, so I propose implementing them.
@and-reas-se and-reas-se changed the title Suggestin: Implement convenience methods from NaiveWeek on IsoWeek Suggestion: Implement convenience methods from NaiveWeek on IsoWeek Sep 11, 2024
@djc
Copy link
Member

djc commented Sep 12, 2024

Makes sense -- I'm happy to review a PR for these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@djc @and-reas-se