Where is the right place to config socket buffer size #58

chronoxor · Apr 24, 2020 · fd4fdc0 · fd4fdc0
1 parent 180e99c
commit fd4fdc0
Show file tree

Hide file tree

Showing 11 changed files with 35 additions and 243 deletions.
diff --git a/.appveyor.yml b/.appveyor.yml
@@ -1,5 +1,5 @@
 # Specify version format
-version: "3.0.11.{build}"
+version: "3.0.12.{build}"
 
 # Image to use
 image: Visual Studio 2019

diff --git a/source/NetCoreServer/NetCoreServer.csproj b/source/NetCoreServer/NetCoreServer.csproj
@@ -2,7 +2,7 @@
 
   <PropertyGroup>
     <TargetFramework>netstandard2.1</TargetFramework>
-    <Version>3.0.11</Version>
+    <Version>3.0.12</Version>
     <Authors>Ivan Shynkarenka</Authors>
     <Copyright>Copyright (c) 2019-2020 Ivan Shynkarenka</Copyright>
     <RepositoryUrl>https://github.com/chronoxor/NetCoreServer</RepositoryUrl>

diff --git a/source/NetCoreServer/SslClient.cs b/source/NetCoreServer/SslClient.cs
@@ -98,49 +98,11 @@ public SslClient(SslContext context, IPEndPoint endpoint)
         /// <summary>
         /// Option: receive buffer size
         /// </summary>
-        public int OptionReceiveBufferSize
-        {
-            get => Socket.ReceiveBufferSize;
-            set => Socket.ReceiveBufferSize = value;
-        }
+        public int OptionReceiveBufferSize { get; set; } = 8192;
         /// <summary>
         /// Option: send buffer size
         /// </summary>
-        public int OptionSendBufferSize
-        {
-            get => Socket.SendBufferSize;
-            set => Socket.SendBufferSize = value;
-        }
-        /// <summary>
-        /// Option: receive timeout in milliseconds
-        /// </summary>
-        /// <remarks>
-        /// The default value is 0, which indicates an infinite time-out period. Specifying -1 also indicates an infinite time-out period.
-        /// </remarks>
-        public int OptionReceiveTimeout
-        {
-            get => Socket.ReceiveTimeout;
-            set => Socket.ReceiveTimeout = value;
-        }
-        /// <summary>
-        /// Option: send timeout in milliseconds
-        /// </summary>
-        /// <remarks>
-        /// The default value is 0, which indicates an infinite time-out period. Specifying -1 also indicates an infinite time-out period.
-        /// </remarks>
-        public int OptionSendTimeout
-        {
-            get => Socket.SendTimeout;
-            set => Socket.SendTimeout = value;
-        }
-        /// <summary>
-        /// Option: linger state
-        /// </summary>
-        public LingerOption OptionLingerState
-        {
-            get => Socket.LingerState;
-            set => Socket.LingerState = value;
-        }
+        public int OptionSendBufferSize { get; set; } = 8192;
 
         #region Connect/Disconnect client
 

diff --git a/source/NetCoreServer/SslServer.cs b/source/NetCoreServer/SslServer.cs
@@ -107,6 +107,14 @@ public SslServer(SslContext context, IPEndPoint endpoint)
         /// This option will enable/disable SO_EXCLUSIVEADDRUSE if the OS support this feature
         /// </remarks>
         public bool OptionExclusiveAddressUse { get; set; }
+        /// <summary>
+        /// Option: receive buffer size
+        /// </summary>
+        public int OptionReceiveBufferSize { get; set; } = 8192;
+        /// <summary>
+        /// Option: send buffer size
+        /// </summary>
+        public int OptionSendBufferSize { get; set; } = 8192;
 
         #region Start/Stop server
 

diff --git a/source/NetCoreServer/SslSession.cs b/source/NetCoreServer/SslSession.cs
@@ -21,6 +21,8 @@ public SslSession(SslServer server)
         {
             Id = Guid.NewGuid();
             Server = server;
+            OptionReceiveBufferSize = server.OptionReceiveBufferSize;
+            OptionSendBufferSize = server.OptionSendBufferSize;
         }
 
         /// <summary>
@@ -57,49 +59,11 @@ public SslSession(SslServer server)
         /// <summary>
         /// Option: receive buffer size
         /// </summary>
-        public int OptionReceiveBufferSize
-        {
-            get => Socket.ReceiveBufferSize;
-            set => Socket.ReceiveBufferSize = value;
-        }
+        public int OptionReceiveBufferSize { get; set; } = 8192;
         /// <summary>
         /// Option: send buffer size
         /// </summary>
-        public int OptionSendBufferSize
-        {
-            get => Socket.SendBufferSize;
-            set => Socket.SendBufferSize = value;
-        }
-        /// <summary>
-        /// Option: receive timeout in milliseconds
-        /// </summary>
-        /// <remarks>
-        /// The default value is 0, which indicates an infinite time-out period. Specifying -1 also indicates an infinite time-out period.
-        /// </remarks>
-        public int OptionReceiveTimeout
-        {
-            get => Socket.ReceiveTimeout;
-            set => Socket.ReceiveTimeout = value;
-        }
-        /// <summary>
-        /// Option: send timeout in milliseconds
-        /// </summary>
-        /// <remarks>
-        /// The default value is 0, which indicates an infinite time-out period. Specifying -1 also indicates an infinite time-out period.
-        /// </remarks>
-        public int OptionSendTimeout
-        {
-            get => Socket.SendTimeout;
-            set => Socket.SendTimeout = value;
-        }
-        /// <summary>
-        /// Option: linger state
-        /// </summary>
-        public LingerOption OptionLingerState
-        {
-            get => Socket.LingerState;
-            set => Socket.LingerState = value;
-        }
+        public int OptionSendBufferSize { get; set; } = 8192;
 
         #region Connect/Disconnect session
 

diff --git a/source/NetCoreServer/TcpClient.cs b/source/NetCoreServer/TcpClient.cs
@@ -83,49 +83,11 @@ public TcpClient(IPEndPoint endpoint)
         /// <summary>
         /// Option: receive buffer size
         /// </summary>
-        public int OptionReceiveBufferSize
-        {
-            get => Socket.ReceiveBufferSize;
-            set => Socket.ReceiveBufferSize = value;
-        }
+        public int OptionReceiveBufferSize { get; set; } = 8192;
         /// <summary>
         /// Option: send buffer size
         /// </summary>
-        public int OptionSendBufferSize
-        {
-            get => Socket.SendBufferSize;
-            set => Socket.SendBufferSize = value;
-        }
-        /// <summary>
-        /// Option: receive timeout in milliseconds
-        /// </summary>
-        /// <remarks>
-        /// The default value is 0, which indicates an infinite time-out period. Specifying -1 also indicates an infinite time-out period.
-        /// </remarks>
-        public int OptionReceiveTimeout
-        {
-            get => Socket.ReceiveTimeout;
-            set => Socket.ReceiveTimeout = value;
-        }
-        /// <summary>
-        /// Option: send timeout in milliseconds
-        /// </summary>
-        /// <remarks>
-        /// The default value is 0, which indicates an infinite time-out period. Specifying -1 also indicates an infinite time-out period.
-        /// </remarks>
-        public int OptionSendTimeout
-        {
-            get => Socket.SendTimeout;
-            set => Socket.SendTimeout = value;
-        }
-        /// <summary>
-        /// Option: linger state
-        /// </summary>
-        public LingerOption OptionLingerState
-        {
-            get => Socket.LingerState;
-            set => Socket.LingerState = value;
-        }
+        public int OptionSendBufferSize { get; set; } = 8192;
 
         #region Connect/Disconnect client
 

diff --git a/source/NetCoreServer/TcpServer.cs b/source/NetCoreServer/TcpServer.cs
@@ -98,6 +98,14 @@ public TcpServer(IPEndPoint endpoint)
         /// This option will enable/disable SO_EXCLUSIVEADDRUSE if the OS support this feature
         /// </remarks>
         public bool OptionExclusiveAddressUse { get; set; }
+        /// <summary>
+        /// Option: receive buffer size
+        /// </summary>
+        public int OptionReceiveBufferSize { get; set; } = 8192;
+        /// <summary>
+        /// Option: send buffer size
+        /// </summary>
+        public int OptionSendBufferSize { get; set; } = 8192;
 
         #region Start/Stop server
 

diff --git a/source/NetCoreServer/TcpSession.cs b/source/NetCoreServer/TcpSession.cs
@@ -20,6 +20,8 @@ public TcpSession(TcpServer server)
         {
             Id = Guid.NewGuid();
             Server = server;
+            OptionReceiveBufferSize = server.OptionReceiveBufferSize;
+            OptionSendBufferSize = server.OptionSendBufferSize;
         }
 
         /// <summary>
@@ -56,49 +58,11 @@ public TcpSession(TcpServer server)
         /// <summary>
         /// Option: receive buffer size
         /// </summary>
-        public int OptionReceiveBufferSize
-        {
-            get => Socket.ReceiveBufferSize;
-            set => Socket.ReceiveBufferSize = value;
-        }
+        public int OptionReceiveBufferSize { get; set; } = 8192;
         /// <summary>
         /// Option: send buffer size
         /// </summary>
-        public int OptionSendBufferSize
-        {
-            get => Socket.SendBufferSize;
-            set => Socket.SendBufferSize = value;
-        }
-        /// <summary>
-        /// Option: receive timeout in milliseconds
-        /// </summary>
-        /// <remarks>
-        /// The default value is 0, which indicates an infinite time-out period. Specifying -1 also indicates an infinite time-out period.
-        /// </remarks>
-        public int OptionReceiveTimeout
-        {
-            get => Socket.ReceiveTimeout;
-            set => Socket.ReceiveTimeout = value;
-        }
-        /// <summary>
-        /// Option: send timeout in milliseconds
-        /// </summary>
-        /// <remarks>
-        /// The default value is 0, which indicates an infinite time-out period. Specifying -1 also indicates an infinite time-out period.
-        /// </remarks>
-        public int OptionSendTimeout
-        {
-            get => Socket.SendTimeout;
-            set => Socket.SendTimeout = value;
-        }
-        /// <summary>
-        /// Option: linger state
-        /// </summary>
-        public LingerOption OptionLingerState
-        {
-            get => Socket.LingerState;
-            set => Socket.LingerState = value;
-        }
+        public int OptionSendBufferSize { get; set; } = 8192;
 
         #region Connect/Disconnect session
 

diff --git a/source/NetCoreServer/UdpClient.cs b/source/NetCoreServer/UdpClient.cs
@@ -94,49 +94,11 @@ public UdpClient(IPEndPoint endpoint)
         /// <summary>
         /// Option: receive buffer size
         /// </summary>
-        public int OptionReceiveBufferSize
-        {
-            get => Socket.ReceiveBufferSize;
-            set => Socket.ReceiveBufferSize = value;
-        }
+        public int OptionReceiveBufferSize { get; set; } = 8192;
         /// <summary>
         /// Option: send buffer size
         /// </summary>
-        public int OptionSendBufferSize
-        {
-            get => Socket.SendBufferSize;
-            set => Socket.SendBufferSize = value;
-        }
-        /// <summary>
-        /// Option: receive timeout in milliseconds
-        /// </summary>
-        /// <remarks>
-        /// The default value is 0, which indicates an infinite time-out period. Specifying -1 also indicates an infinite time-out period.
-        /// </remarks>
-        public int OptionReceiveTimeout
-        {
-            get => Socket.ReceiveTimeout;
-            set => Socket.ReceiveTimeout = value;
-        }
-        /// <summary>
-        /// Option: send timeout in milliseconds
-        /// </summary>
-        /// <remarks>
-        /// The default value is 0, which indicates an infinite time-out period. Specifying -1 also indicates an infinite time-out period.
-        /// </remarks>
-        public int OptionSendTimeout
-        {
-            get => Socket.SendTimeout;
-            set => Socket.SendTimeout = value;
-        }
-        /// <summary>
-        /// Option: linger state
-        /// </summary>
-        public LingerOption OptionLingerState
-        {
-            get => Socket.LingerState;
-            set => Socket.LingerState = value;
-        }
+        public int OptionSendBufferSize { get; set; } = 8192;
 
         #region Connect/Disconnect client
 

diff --git a/source/NetCoreServer/UdpServer.cs b/source/NetCoreServer/UdpServer.cs
@@ -95,49 +95,11 @@ public UdpServer(IPEndPoint endpoint)
         /// <summary>
         /// Option: receive buffer size
         /// </summary>
-        public int OptionReceiveBufferSize
-        {
-            get => Socket.ReceiveBufferSize;
-            set => Socket.ReceiveBufferSize = value;
-        }
+        public int OptionReceiveBufferSize { get; set; } = 8192;
         /// <summary>
         /// Option: send buffer size
         /// </summary>
-        public int OptionSendBufferSize
-        {
-            get => Socket.SendBufferSize;
-            set => Socket.SendBufferSize = value;
-        }
-        /// <summary>
-        /// Option: receive timeout in milliseconds
-        /// </summary>
-        /// <remarks>
-        /// The default value is 0, which indicates an infinite time-out period. Specifying -1 also indicates an infinite time-out period.
-        /// </remarks>
-        public int OptionReceiveTimeout
-        {
-            get => Socket.ReceiveTimeout;
-            set => Socket.ReceiveTimeout = value;
-        }
-        /// <summary>
-        /// Option: send timeout in milliseconds
-        /// </summary>
-        /// <remarks>
-        /// The default value is 0, which indicates an infinite time-out period. Specifying -1 also indicates an infinite time-out period.
-        /// </remarks>
-        public int OptionSendTimeout
-        {
-            get => Socket.SendTimeout;
-            set => Socket.SendTimeout = value;
-        }
-        /// <summary>
-        /// Option: linger state
-        /// </summary>
-        public LingerOption OptionLingerState
-        {
-            get => Socket.LingerState;
-            set => Socket.LingerState = value;
-        }
+        public int OptionSendBufferSize { get; set; } = 8192;
 
         #region Connect/Disconnect client
 

diff --git a/tests/tests.csproj b/tests/tests.csproj
@@ -6,7 +6,7 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.5.0" />
+    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.6.1" />
     <PackageReference Include="xunit" Version="2.4.1" />
     <PackageReference Include="xunit.runner.visualstudio" Version="2.4.1">
       <PrivateAssets>all</PrivateAssets>