Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

method createScene2() does not work on Android #34

Open
mehdighaharian opened this issue Jan 20, 2018 · 11 comments
Open

method createScene2() does not work on Android #34

mehdighaharian opened this issue Jan 20, 2018 · 11 comments

Comments

@mehdighaharian
Copy link

In Chapter5.cpp there is a call to createScene2() inside a callback method:

Director::getInstance()->replaceScene(createScene2());

I ran this Chapter5.cpp without any problem on Linux (Xubuntu 16.04), but it doesn't work on Android.
Actually, on Android the scene1 showed but when I tap on "Make A New Scene" the app crashes!
I tested it on three devices: HTC one X9 (API 23) , HTC one XL (API 17) and Nexux 5x (API 26). All of them crashed when I tapped on "Make A New Scene" in chapter5.
What is it for?

@minggo
Copy link

minggo commented Jan 22, 2018

@slackmoehrle is the new doc uses the same sample repo?

@slackmoehrle
Copy link
Contributor

We havent updated the samples in a long time but yes the docs sample code is based upon this repo

@slackmoehrle
Copy link
Contributor

@minggo Perhaps I should spend some time updating these samples to work again on iOS and Android? @linshun what do you think? We haven't touched these in a while. This is our sample code that goes along with the Programmers Guide content.

@minggo
Copy link

minggo commented Jan 23, 2018

Yep, i think it is needed if new docs use it.

@linshun
Copy link
Member

linshun commented Jan 23, 2018

I agree that we should update it if it is used in new docs.

@slackmoehrle
Copy link
Contributor

slackmoehrle commented Jan 23, 2018

OK. I will do it in the next few days. I have been working on the discourse upgrading.

@slackmoehrle
Copy link
Contributor

@mehdighaharian can you tell me which branch you are using?

@mehdighaharian
Copy link
Author

@slackmoehrle
I opened the main page of programmers-guide-samples and didn't pay attention to which branch I wanted to download. Then downloaded it as a zip file.
So, I think I used default branch which is v3.10 .

@slackmoehrle
Copy link
Contributor

@mehdighaharian I think v3.16 should work fine on Android. I think I am going to update the v3.16 branch to use Android Studio though.

@mehdighaharian
Copy link
Author

@slackmoehrle I will test v3.16 on my Android devices as soon as possible. I will post the result here.
Good to mention that I am using stable version 3.16 to compile the classes.

@mehdighaharian
Copy link
Author

I downloaded the branch v3.16 and copied the codes into the project and compiled with android-25.
I tested it on the same devices I mentioned earlier. Only on HTC oneXL (api 17) the probelm was solved. But on two other devices, it didn't work.
My HTC oneXL has a custom rom.
Has anyone tested the branch v3.16 on any device without any problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants