Refactor app.js to remove redundant code in ciderPlaybackAction handler

ciderapp · Aug 24, 2024 · ad5c987 · ad5c987
1 parent 27fea93
commit ad5c987
Showing 1 changed file with 17 additions and 15 deletions.
diff --git a/src/sh.cider.streamdeck.sdPlugin/app.js b/src/sh.cider.streamdeck.sdPlugin/app.js
@@ -130,20 +130,6 @@ Object.keys(actions).forEach(actionKey => {
             case 'ciderLogoAction':
                 console.warn(`[DEBUG] [Action] User must be high, why you clicking the logo?`);
                 break;
-            case 'ciderPlaybackAction':
-                switch (tapBehavior) {
-                    case 'addToLibrary':
-                        addToLibrary();
-                        break;
-                    case 'favorite':
-                        setRating(1);
-                        break;
-                    default:
-                        addToLibrary();
-                        setRating(1);
-                        break;
-                }
-                break;
             default:
                 console.warn(`[DEBUG] [Action] No handler for ${actionKey}`);
                 break;
@@ -153,7 +139,7 @@ Object.keys(actions).forEach(actionKey => {
     if (actionKey === 'ciderPlaybackAction') {
         action.onDialDown(() => {
             console.debug(`[DEBUG] [Action] ciderPlaybackAction dial pressed`);
-            switch (pressBehavior) {
+            switch (window.pressBehavior) {
                 case 'togglePlay':
                     comRPC("POST", "playpause");
                     break;
@@ -169,6 +155,22 @@ Object.keys(actions).forEach(actionKey => {
         action.onDialRotate((jsonObj) => {
             handleVolumeChange(actions.ciderPlaybackAction, window.contexts.ciderPlaybackAction[0], null, jsonObj.payload);
         });
+
+        action.onTouchTap(() => {
+            console.debug(`[DEBUG] [Action] ciderPlaybackAction touch tapped`);
+            switch (window.tapBehavior) {
+                case 'addToLibrary':
+                    addToLibrary();
+                    break;
+                case 'favorite':
+                    setRating(1);
+                    break;
+                case 'both':
+                    addToLibrary();
+                    setRating(1);
+                    break;
+            }
+        });
     }
 });