Skip to content

Commit f1182c8

Browse files
committed
Long mapping message instead of wide
1 parent e15e90f commit f1182c8

File tree

3 files changed

+30
-40
lines changed

3 files changed

+30
-40
lines changed

lib/DataHarmonizer.js

+13-16
Original file line numberDiff line numberDiff line change
@@ -1346,23 +1346,20 @@ class DataHarmonizer {
13461346
let flatHeaders = this.getFlatHeaders();
13471347
const self = this;
13481348
if (flatHeaders) {
1349-
$('#field-mapping').prepend(
1350-
'<col></col>'.repeat(flatHeaders[1].length + 1)
1351-
);
1352-
$('#expected-headers-tr').html(
1353-
'<td><b>Expected second row</b></td> <td>' +
1354-
flatHeaders[1].join('</td><td>') +
1355-
'</td>'
1356-
);
1357-
$('#actual-headers-tr').html(
1358-
'<td><b>Imported second row</b></td> <td>' +
1359-
matrix[1].join('</td><td>') +
1360-
'</td>'
1361-
);
1362-
flatHeaders[1].forEach(function (item, i) {
1363-
if (item != matrix[1][i]) {
1364-
$('#field-mapping col').get(i + 1).style.backgroundColor = 'orange';
1349+
const $fieldMappingBody = $('#field-mapping-body');
1350+
flatHeaders[1].forEach(function (expectedHeader, i) {
1351+
const expectedHeaderCell =
1352+
`<td class="field-mapping-cell">${expectedHeader}</td>`
1353+
const actualHeaderCell =
1354+
`<td class="field-mapping-cell">${matrix[1][i]}</td>`;
1355+
const rowCells = expectedHeaderCell + actualHeaderCell;
1356+
let row;
1357+
if (expectedHeader !== matrix[1][i]) {
1358+
row = $(`<tr class="table-warning">${rowCells}</tr>`);
1359+
} else {
1360+
row = $(`<tr>${rowCells}</tr>`);
13651361
}
1362+
$fieldMappingBody.append(row);
13661363
});
13671364

13681365
$('#specify-headers-modal').modal('show');

lib/data-harmonizer.css

+6-18
Original file line numberDiff line numberDiff line change
@@ -5,17 +5,16 @@
55
}
66

77
#specify-headers-comparison-row {
8-
overflow-x: auto;
8+
overflow-y: auto;
99
}
1010

1111
#specify-headers-err-msg {
1212
display: none;
1313
}
1414

1515
#field-mapping-container {
16-
overflow-x: scroll;
17-
padding-bottom: 1rem;
18-
scrollbar-width: 1rem;
16+
height: 25vh;
17+
width: 100%;
1918
}
2019

2120
.handsontable.listbox th,
@@ -24,20 +23,9 @@
2423
}
2524

2625
#field-mapping {
27-
white-space: nowrap;
26+
width: 100%;
2827
}
2928

30-
#field-mapping col {
31-
border-left: 2px solid black;
32-
}
33-
#field-mapping col:first-child {
34-
background: #ff0;
35-
}
36-
#field-mapping col:nth-child(2n + 3) {
37-
background: #ccc;
38-
}
39-
40-
#field-mapping tr td,
41-
#field-mapping tr th {
42-
padding: 3px;
29+
.field-mapping-cell {
30+
width: 50%;
4331
}

lib/specifyHeadersModal.html

+11-6
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,17 @@
99
column specification. Mismatched column(s) are shown in orange.
1010
</div>
1111
</div>
12-
<div class="row my-3 border" id="specify-headers-comparison-row">
13-
<div class="col">
14-
<div class="row" id="field-mapping-container">
15-
<table id="field-mapping">
16-
<tr id="expected-headers-tr"></tr>
17-
<tr id="actual-headers-tr"></tr>
12+
<div class="row my-2" id="specify-headers-comparison-row">
13+
<div class="col px-0 py-1">
14+
<div id="field-mapping-container" class="container-fluid">
15+
<table id="field-mapping" class="table-bordered">
16+
<thead>
17+
<tr>
18+
<th class="field-mapping-cell">Expected header</th>
19+
<th class="field-mapping-cell">Actual header</th>
20+
</tr>
21+
</thead>
22+
<tbody id="field-mapping-body"></tbody>
1823
</table>
1924
</div>
2025
</div>

0 commit comments

Comments
 (0)