-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Windows Terminal #37
Open
vwheeler63
wants to merge
9
commits into
ciembor:master
Choose a base branch
from
vwheeler63:vwheeler63/win_terminal_support
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add support for Windows Terminal #37
vwheeler63
wants to merge
9
commits into
ciembor:master
from
vwheeler63:vwheeler63/win_terminal_support
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why needed: Windows Termimal has a 'settings.json' file that can house color schemes. It requires a certain syntax and its own set of color names. How addressed: Similar to other output types, I generated an output to the browser with syntactically correct color scheme instance for Windows Terminal 'settings.json', with instructions on where to copy/paste it to, and indentation matching the indent level for color schemes in that file. Also updated README.md to reflect addition of Windows Terminal and myself as a contributor. Accomplishes: A copy/paste interface to Windows Terminal settings file. User must still copy and past the color scheme into place, and give it a name, but the rest is syntacially correct. This highlights the need for the ability to "open" a color scheme from Windows Terminal, tweak it, and save it back to the same color scheme or give it a new name.
Why needed: "Get Scheme" string was word-wrapping with "Scheme" appearing partially below the button. How addressed: Widened button from 116px to 126px. Word wrap stopped.
URL: https://github.com/mbadolato/iTerm2-Color-Schemes Note: this also follows the color-wheel sequence.
vwheeler63
force-pushed
the
vwheeler63/win_terminal_support
branch
from
August 10, 2020 19:22
fda8e9d
to
db2c1ae
Compare
I visited 4bit website for generating Windows Terminal Scheme but didn't find any color set. I had to set custom theme manually. Shall I create specific 'Windows Terminal' button for it ? |
That would be very welcome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why needed:
Windows Termimal has a 'settings.json' file that can house color schemes.
It requires a certain syntax and its own set of color names.
How addressed:
Similar to other output types, I generated an output to the browser
with syntactically correct color scheme instance for Windows Terminal
'settings.json', with instructions on where to copy/paste it to, and
indentation matching the indent level for color schemes in that file.
Also updated README.md to reflect addition of Windows Terminal and
myself as a contributor.
Accomplishes:
A copy/paste interface to Windows Terminal settings file. User must
still copy and past the color scheme into place, and give it a name,
but the rest is syntacially correct.
This highlights the need for the ability to "open" a color scheme
from Windows Terminal, tweak it, and save it back to the same color
scheme or give it a new name.