Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Windows Terminal #37

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

vwheeler63
Copy link

Why needed:
Windows Termimal has a 'settings.json' file that can house color schemes.
It requires a certain syntax and its own set of color names.

How addressed:
Similar to other output types, I generated an output to the browser
with syntactically correct color scheme instance for Windows Terminal
'settings.json', with instructions on where to copy/paste it to, and
indentation matching the indent level for color schemes in that file.
Also updated README.md to reflect addition of Windows Terminal and
myself as a contributor.

Accomplishes:
A copy/paste interface to Windows Terminal settings file. User must
still copy and past the color scheme into place, and give it a name,
but the rest is syntacially correct.

This highlights the need for the ability to "open" a color scheme
from Windows Terminal, tweak it, and save it back to the same color
scheme or give it a new name.

Victor Wheeler added 9 commits August 9, 2020 13:08
Why needed:
  Windows Termimal has a 'settings.json' file that can house color schemes.
  It requires a certain syntax and its own set of color names.

How addressed:
  Similar to other output types, I generated an output to the browser
  with syntactically correct color scheme instance for Windows Terminal
  'settings.json', with instructions on where to copy/paste it to, and
  indentation matching the indent level for color schemes in that file.
  Also updated README.md to reflect addition of Windows Terminal and
  myself as a contributor.

Accomplishes:
  A copy/paste interface to Windows Terminal settings file.  User must
  still copy and past the color scheme into place, and give it a name,
  but the rest is syntacially correct.

  This highlights the need for the ability to "open" a color scheme
  from Windows Terminal, tweak it, and save it back to the same color
  scheme or give it a new name.
Why needed:
  "Get Scheme" string was word-wrapping with "Scheme" appearing partially
  below the button.

How addressed:
  Widened button from 116px to 126px.  Word wrap stopped.
@vwheeler63 vwheeler63 force-pushed the vwheeler63/win_terminal_support branch from fda8e9d to db2c1ae Compare August 10, 2020 19:22
@adsingh14
Copy link

I visited 4bit website for generating Windows Terminal Scheme but didn't find any color set. I had to set custom theme manually. Shall I create specific 'Windows Terminal' button for it ?

@vwheeler63
Copy link
Author

I visited 4bit website for generating Windows Terminal Scheme but didn't find any color set. I had to set custom theme manually. Shall I create specific 'Windows Terminal' button for it ?

That would be very welcome!

@adsingh14
Copy link

I visited 4bit website for generating Windows Terminal Scheme but didn't find any color set. I had to set custom theme manually. Shall I create specific 'Windows Terminal' button for it ?

That would be very welcome!

Please have a look at #41 . That'd be helpful to make this happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants