Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make layout be immutable #7

Open
c-dante opened this issue Aug 22, 2016 · 0 comments
Open

Make layout be immutable #7

c-dante opened this issue Aug 22, 2016 · 0 comments

Comments

@c-dante
Copy link

c-dante commented Aug 22, 2016 •
edited by sandersky
Loading

Layout is already copying the graph -- why not let it be immutable?

Just export each of the layout functions: buildLayoutGraph, runLayout, and updateInputGraph.

Also, you could just return the layoutGraph and let someone else merge it in if they want.

https://github.com/ciena-blueplanet/dagre/blob/master/src/layout.js#L416
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@c-dante