Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update confirm/error/info/warn dialogs to have promise-aware confirm behavior #127

Open
gknoy opened this issue Jan 10, 2018 · 2 comments
Open

Update confirm/error/info/warn dialogs to have promise-aware confirm behavior #127

gknoy opened this issue Jan 10, 2018 · 2 comments

Comments

@gknoy
Copy link

gknoy commented Jan 10, 2018

Once the frost-modal-form dialog supports promise-aware confirmation and optional confirm-button disabling (PR 125), we should also update the confirm, error, info, and warn dialogs to use the computed confirmButtonProps property, rather than directly using confirm.
@gknoy gknoy mentioned this issue Jan 10, 2018
Merged
4 tasks
@notmessenger
Copy link
Contributor

This is related to the // TODO entries (and possibly code without // TODO entries) introduced in #125

@notmessenger
Copy link
Contributor

@gknoy you already addressed this, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@notmessenger @gknoy