Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOI url bug between ckan and metadata form #230

Closed
pauline-chauvet opened this issue Feb 16, 2023 · 9 comments · Fixed by #258
Closed

DOI url bug between ckan and metadata form #230

pauline-chauvet opened this issue Feb 16, 2023 · 9 comments · Fixed by #258
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@pauline-chauvet
Copy link

When we put the DOI url in the form: https://doi.org/10.26071/ogsl-m3x6-fh43
it says that the entry is not correct
image
However, if we only put the number:10.26071/ogsl-m3x6-fh43, then there is a problem in the catalog

without url
image

with url
image

@pauline-chauvet
Copy link
Author

hope my issue is clear, otherwise, don't hesitate to contact me

@fostermh
Copy link
Member

It appears that I need to adjust the parsing of DOI's in CKAN. I thought this was working but perhaps I'm not accounting for the dashes. On a related note, it would be very convenient if the metadata form stored the full URL in the XML rather than just the identifier. Could we change the DOI input in the metadata form to allow/encourage full URLS?

@pauline-chauvet
Copy link
Author

"Could we change the DOI input in the metadata form to allow/encourage full URLS?"

I agree with Mat as it would also be helpful when we use the eml for OBIS IPT, right now, I have to correct it manually

@n-a-t-e
Copy link
Member

n-a-t-e commented Feb 16, 2023

I agree as well, it should come out as a complete URL in the XML/YAML/EML/ERDDAP outputs

@n-a-t-e n-a-t-e added bug Something isn't working good first issue Good for newcomers labels Feb 16, 2023
@fostermh fostermh linked a pull request Nov 7, 2023 that will close this issue
@n-a-t-e
Copy link
Member

n-a-t-e commented Nov 22, 2023

Reopening this - one last step needed is any records that have been saved without the https://doi.org/ prefix need to be update in the database to include it. Otherwise these records appear as "invalid" in the metadata form, and eg can't use the download to XML/EML options

@fostermh
Copy link
Member

I think the database update has been done, need to confirm.

@BryceMarshall
Copy link
Contributor

It looks like all DOI URLs have been updated - though I did identify that there are ~120 entries that have that field populated with a non-DOI entry e.g.

"datasetIdentifier": "https://doi.org/10.48689/736c4721-db8e-4116-a5f8-d9084126b135"

vs

"datasetIdentifier": "Eelgrass Extent Field Data (2018) - Kelp Beds"

Is this something that needs to be addressed as well?

@fostermh
Copy link
Member

fostermh commented Mar 7, 2024

I think that is ok for us but is perhaps something that @Br-Johnson, @timvdstap and @JessyBarrette should know about for eh future

@JessyBarrette
Copy link
Collaborator

JessyBarrette commented Mar 8, 2024

Thanks @fostermh @BryceMarshall Yes will address that in a coming sprint :) At least of the Hakai specific related one for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants