Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download and Publish functions broken for records with multiple platforms #359

Open
sjbruce opened this issue Apr 25, 2024 · 2 comments
Open
Labels
bug Something isn't working
Milestone

Comments

@sjbruce
Copy link
Contributor

sjbruce commented Apr 25, 2024

The addition of multiple platforms seems to have broken the download and publish functions of the form.

If a record still possesses the previous structure assuming a single platform the record will be published and can be downloaded with the older values. The multiple platforms are not present in the published/downloaded files.

The same is true for the YAML download.

XHRPOST
https://us-central1-cioos-metadata-form.cloudfunctions.net/downloadRecord
[HTTP/3 500  250ms]

	
error	Object { message: "INTERNAL", status: "INTERNAL" }
message	"INTERNAL"
status	"INTERNAL"
FirebaseError: INTERNAL
    Fs errors.ts:85
    Fp error.ts:68
    c error.ts:168
    Vp service.ts:315
    Wp service.ts:260
    Wp service.ts:185
    B MetadataRecordListItem.jsx:108
    onClick MetadataRecordListItem.jsx:347
    React 12
    unstable_runWithPriority scheduler.production.min.js:19
    React 3
    r helpers.ts:87
instrument.ts:129:35
@sjbruce sjbruce added the bug Something isn't working label Apr 25, 2024
@sjbruce
Copy link
Contributor Author

sjbruce commented Apr 25, 2024

It also appears that the only records that can be downloaded are ones that have been recently published.

I assume this has to do with the expansion of required fields in the recent updates, regardless of publication status?

Screenshot_042524_043751_PM

@fostermh
Copy link
Member

this is due to the records no longer passing validation because some fields are not set. Once a record is edited and updated to pass validation it will be downloadable again. We could consider a nulk update but it might make more sense to manually review each record for accuracy anyway.

@fostermh fostermh added this to the v2.0 milestone May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Development

No branches or pull requests

2 participants