Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

select resource type on start page #314

Closed
wants to merge 4 commits into from

Conversation

sorochak
Copy link
Contributor

@sorochak sorochak commented Jan 31, 2024

This PR solves issue #264

So far all that's been done is the addition of radio buttons on the start page allowing users to select 'Resource Type' from three options, 'Oceanographic', 'Biological', 'Model'. The selection updates the record object with the field resourceType.

@sorochak sorochak requested a review from fostermh January 31, 2024 20:00
@sorochak sorochak self-assigned this Jan 31, 2024
@sorochak sorochak linked an issue Jan 31, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Jan 31, 2024

Visit the preview URL for this PR (updated for commit 24280f0):

https://cioos-metadata-form--pr314-264-select-resource-wcj7va35.web.app

(expires Thu, 21 Mar 2024 23:48:34 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 57eda2a7622dc877ccadb675a0532261c52b09fd

@sorochak
Copy link
Contributor Author

sorochak commented Jan 31, 2024

The issue mentions that this depends on #240. These changes have yet to be merged.

I had a question regarding what do we want to happen when a resource type is selected. This may be sorted by merging PRs associated with issue 240?

There were also comments on selecting what wording to be used (ie. 'Resource type' etc).

@Br-Johnson
Copy link
Contributor

I feel like this touches on a number of open questions...

  1. Do we wan't the form to be adaptive depending on what resource type is selected? Eg:
  • include EOVs or not,
  • include EML fields or not,
  • require lineage if Model is selected... Couple of options there...
  1. Is this idea for this selection to fill out MD_metadataScope>resourceScope? I see that's being set in the Lineage PR

@fostermh
Copy link
Member

fostermh commented Feb 2, 2024

The intention with this would be to select the type of record we are filling out, not necessarily the resource type field. for example, we might select a biological type which would hide/show some fields but still select 'dataset' as the resource type

@sorochak
Copy link
Contributor Author

sorochak commented Feb 2, 2024

we might select a biological type which would hide/show some fields but still select 'dataset' as the resource type

I guess this is where the 'resource type' wording confusion comes in...

@fostermh fostermh mentioned this pull request Feb 22, 2024
@fostermh
Copy link
Member

fostermh commented Mar 7, 2024

replaced by #322

@fostermh fostermh closed this Mar 7, 2024
@fostermh fostermh deleted the 264-select-resource-type-start-page branch April 11, 2024 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Select resource type (dataset, model, etc) on start page?
3 participants