309 Enhancement of Environment Variable Handling #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
Visit the preview URL for this PR (updated for commit a7b0d9e): https://cioos-metadata-form--pr315-309-improve-env-conf-e9y7q7hw.web.app (expires Sun, 03 Mar 2024 23:38:01 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 57eda2a7622dc877ccadb675a0532261c52b09fd |
Env varibles 2
sorochak
changed the title
fostermh
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses the issue #309, related to the lack of checks for necessary Authentication environment variables, which was leading to deployment issues and runtime errors.
Key Changes:
Introduction of Parameterized Configuration: The CLI will prompt for parameter values during deployment if they are not preset. This helps prevent functions from being deployed with missing credentials if maintainers deploy from their local machine.
**Improvements to
firebase-deployGitHub Actions workflow **: Automated creation of a virtual.envfile as part of the deployment workflow to ensure all required environment variables are set.Added Firebase Functions Deployment and Config Process in README: Modified the README with instructions to advise maintainers to utilize the 'Deploy Firebase Functions' workflow on their feature branches, ensuring a consistent deployment environment.