Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Switch to torchvision for MNIST Dataset loading #15

Closed
stroblme opened this issue Aug 21, 2023 · 1 comment
Closed

FR: Switch to torchvision for MNIST Dataset loading #15

stroblme opened this issue Aug 21, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@stroblme
Copy link
Member

Is your feature request related to a problem? Please describe.
Currently there is a dependency on tensorflow only for loading the MNIST dataset.
Furthermore the MNIST dataset has to be loaded manually into the appropriate folder.

Describe the solution you'd like
Use the dataset handler available with torchvision for loading the MNIST dataset.

Describe alternatives you've considered
Alternatively we could use a manual approach where we introduce a custom Dataset for Kedro that inherits from the Abstract Dataset class and handles the loading and providing of MNIST data internally.
Although this approach might be more in the spirit of Kedro, it is also more prone to errors and potentially more time consuming compared to the well established code from torchvision that would allow an almost drop-in replacement with the existing code.

Additional context
N/A

@stroblme stroblme added the enhancement New feature or request label Aug 21, 2023
@stroblme
Copy link
Member Author

Postponed as not urgent and switching to torchvision requires quite some restructuring of code as torch returns full dataloader object that would break the current preprocessing pipeline

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants