Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRAFT: CIRC-4436 - Allow stacktrace across an eventer asynch #740

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

DRAFT: CIRC-4436 - Allow stacktrace across an eventer asynch #740

wants to merge 2 commits into from

Conversation

vasuraman11
Copy link
Contributor

This branch allows libmtev to stacktrace beyond mtev_run_callback and show what the stacktrace was when eventer_add was called. That allows us to get a greater context if a crash occurs.

postwait
postwait reviewed Nov 25, 2020
View reviewed changes
Copy link
Member

@postwait postwait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This increases the eventer_t by over a kilobyte.

This should be implemented as an optional module that leverages the existing eventer_context_t as zipkin does.

@postwait
Copy link
Member

I also thing that zipking provides a lot of this already. I think we should close this for a different approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@postwait postwait postwait left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vasuraman11 @postwait