Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lineage pull request for: skeleton #31

Merged
merged 63 commits into from
Nov 13, 2024
Merged

Lineage pull request for: skeleton #31

merged 63 commits into from
Nov 13, 2024

Commits on Feb 14, 2024

  1. Add checks for semantic python versions

    Michael Saki committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    33582a1 View commit details
    Browse the repository at this point in the history
  2. Refactor code for the semantic check

    This commit will make a few changes. The
    orginal version of the semantic checking
    function was a bit more difficult to read.
    It is now somewhat easier to follow how
    the regex is structured. Also the function
    has been renamed to check_python_version
    since it has 2 functions, making sure that
    the version is semantically correct and the
    second is to make sure that it is installed
    on the user's machine. This makes it easier
    to follow the logic for the flags, -p or
    --python-version and -l or --list-versions
    Michael Saki committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    9438194 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2024

  1. Add checks for semantic python versions

    Michael Saki committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    cea8edc View commit details
    Browse the repository at this point in the history
  2. Refactor code for the semantic check

    This commit will make a few changes. The
    orginal version of the semantic checking
    function was a bit more difficult to read.
    It is now somewhat easier to follow how
    the regex is structured. Also the function
    has been renamed to check_python_version
    since it has 2 functions, making sure that
    the version is semantically correct and the
    second is to make sure that it is installed
    on the user's machine. This makes it easier
    to follow the logic for the flags, -p or
    --python-version and -l or --list-versions
    Michael Saki committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    d5c7c4a View commit details
    Browse the repository at this point in the history
  3. Merge branch 'improvement/correct-semantic-python-version-checks' of h…

    …ttps://github.com/cisagov/skeleton-generic into improvement/correct-semantic-python-version-checks
    Michael Saki committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    f7b9d05 View commit details
    Browse the repository at this point in the history
  4. Remove example of correct semantic version

    Michael Saki committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    327ab73 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2024

  1. Refactor the error message for the user

    Michael Saki committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    4dedf50 View commit details
    Browse the repository at this point in the history
  2. Improve the semantic error message

    Michael Saki committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    e84deea View commit details
    Browse the repository at this point in the history
  3. Fix grammar

    Co-authored-by: dav3r <[email protected]>
    michaelsaki and dav3r authored Mar 20, 2024
    Configuration menu
    Copy the full SHA
    5fdc7be View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2024

  1. Refactor regex, add link, and improve comments

    Michael Saki committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    42ef8c2 View commit details
    Browse the repository at this point in the history
  2. Update link to use semver.org over regex101.com

    Michael Saki committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    a77e5e1 View commit details
    Browse the repository at this point in the history
  3. Remove unnecessary period

    Co-authored-by: dav3r <[email protected]>
    michaelsaki and dav3r authored Mar 21, 2024
    Configuration menu
    Copy the full SHA
    5fe14c7 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2024

  1. Add a meta hook to the pre-commit configuration

    Add the `check-useless-excludes` meta hook to verify that any defined
    `exclude` directives apply to at least one file in the repository.
    mcdonnnj committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    b7896a0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    260566f View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2024

  1. Configuration menu
    Copy the full SHA
    a68994d View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2024

  1. Use the hashicorp/setup-packer GitHub Action

    Instead of manually installing Packer we can instead leverage the
    hashicorp/setup-packer Action just as we do for Terraform.
    mcdonnnj committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    43b91c7 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2024

  1. Remove @jasonodoom as a codeowner

    He is no longer a member of @cisagov/vm-dev.
    jsf9k committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    8ada75d View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2024

  1. Pin to a specific version

    Previously we only provided a lower bound for the version, but pinning to a specific version aligns with what has been done with the prettier hook and how pre-commit hooks are pinned in general.
    
    The flake8-docstrings package is rarely updated, so there is no real downside to pinning to a specific version.
    
    Co-authored-by: Nick <[email protected]>
    jsf9k and mcdonnnj authored Aug 26, 2024
    Configuration menu
    Copy the full SHA
    2930208 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. Bump actions/cache from 3 to 4

    Bumps [actions/cache](https://github.com/actions/cache) from 3 to 4.
    - [Release notes](https://github.com/actions/cache/releases)
    - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
    - [Commits](actions/cache@v3...v4)
    
    ---
    updated-dependencies:
    - dependency-name: actions/cache
      dependency-type: direct:production
      update-type: version-update:semver-major
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    dependabot[bot] authored Sep 24, 2024
    Configuration menu
    Copy the full SHA
    46e0553 View commit details
    Browse the repository at this point in the history
  2. Bump crazy-max/ghaction-github-status from 3 to 4

    Bumps [crazy-max/ghaction-github-status](https://github.com/crazy-max/ghaction-github-status) from 3 to 4.
    - [Release notes](https://github.com/crazy-max/ghaction-github-status/releases)
    - [Commits](crazy-max/ghaction-github-status@v3...v4)
    
    ---
    updated-dependencies:
    - dependency-name: crazy-max/ghaction-github-status
      dependency-type: direct:production
      update-type: version-update:semver-major
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    dependabot[bot] authored Sep 24, 2024
    Configuration menu
    Copy the full SHA
    3167421 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. Update pre-commit hook versions

    This is done automatically with the `pre-commit autoupdate` command.
    The pre-commit/mirrors-prettier hook was manually held back because the
    latest tags are for alpha releases of the next major version.
    mcdonnnj committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    6a58c2c View commit details
    Browse the repository at this point in the history
  2. Manually update the prettier hook

    Use the latest v3 release available from NPM.
    mcdonnnj committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    553efcb View commit details
    Browse the repository at this point in the history
  3. Merge pull request #170 from cisagov/dependabot/github_actions/crazy-…

    …max/ghaction-github-status-4
    
    Bump crazy-max/ghaction-github-status from 3 to 4
    mcdonnnj authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    184e749 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #171 from cisagov/dependabot/github_actions/action…

    …s/cache-4
    
    Bump actions/cache from 3 to 4
    mcdonnnj authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    d99c117 View commit details
    Browse the repository at this point in the history
  5. Merge pull request #187 from cisagov/improvement/use_setup_packer_action

    Use an Action to install Packer in our GitHub Actions workflows
    mcdonnnj authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    2491ca0 View commit details
    Browse the repository at this point in the history
  6. Merge pull request #176 from cisagov/improvement/correct-semantic-pyt…

    …hon-version-checks
    
    Add checks for correct semantic version of Python
    mcdonnnj authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    f6c9537 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    10e5f6f View commit details
    Browse the repository at this point in the history
  8. Add a pre-commit hook to run pip-audit

    The pip-audit tool will audit any supplied pip requirements files for
    vulnerable packages.
    mcdonnnj committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    045a998 View commit details
    Browse the repository at this point in the history
  9. Merge pull request #178 from cisagov/improvement/add_pre-commit_meta_…

    …hook
    
    Add the `check-useless-excludes` hook to the pre-commit configuration
    mcdonnnj authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    28dc4ce View commit details
    Browse the repository at this point in the history
  10. Merge pull request #179 from cisagov/improvement/add_pip-audit_pre-co…

    …mmit_hook
    
    Add a pre-commit hook to run `pip-audit`
    mcdonnnj authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    5801cec View commit details
    Browse the repository at this point in the history
  11. Merge pull request #184 from cisagov/improvement/pin-flake8-docstrings

    Add a lower-bound pin for the `flake8-docstrings` `pip` package
    mcdonnnj authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    e61255c View commit details
    Browse the repository at this point in the history
  12. Merge pull request #185 from cisagov/maintenance/update_pre-commit_hooks

    Update `pre-commit` hooks
    mcdonnnj authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    44cd1be View commit details
    Browse the repository at this point in the history
  13. Use the rbubley/mirrors-prettier hook for prettier

    This replaces the now archived pre-commit/mirrors-prettier hook.
    mcdonnnj committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    c502f1a View commit details
    Browse the repository at this point in the history
  14. Merge pull request #186 from cisagov/improvement/switch_prettier_hook

    Switch the `pre-commit` hook used to run `prettier`
    mcdonnnj authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    f0e55b3 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. Add a new trigger for the sync-labels GitHub Actions workflow

    Add a `workflow_dispatch` trigger so we can manually run the workflow
    if needed.
    mcdonnnj committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    942c0dc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a267662 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    dc7f09e View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. Specify all variables as non-nullable

    This means that we need not worry about whether variables are
    explicitly specified as null.  Since this is not something we were
    expecting, it makes sense to avoid the situation.
    
    See also:
    https://developer.hashicorp.com/terraform/language/values/variables#disallowing-null-input-values
    jsf9k committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    7bf438d View commit details
    Browse the repository at this point in the history
  2. Bump the required version of Terraform up to 1.1

    Version 1.1 of Terraform is the first version to support the nullable
    key in variable definitions.
    
    Also update the comment associated with this line to something a bit
    more truthful, since we are using 1.5.7 in
    cisagov/setup-env-github-action.
    
    Co-authored-by: David Redmin <[email protected]>
    jsf9k and dav3r committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    c551420 View commit details
    Browse the repository at this point in the history
  3. Update terraform-docs content in README.md

    Co-authored-by: David Harris <[email protected]>
    jsf9k and dv4harr10 committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    e57dd10 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    193083a View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2024

  1. Add the GitHubSecurityLab/actions-permissions/monitor Action

    This Action will provide information about the usage of GITHUB_TOKEN in
    the workflow. It should be added to _every_ job in _any_ workflow to
    provide information for analysis.
    mcdonnnj committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    343d2cc View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2024

  1. Restrict permissions of GITHUB_TOKEN

    This changes the default permissions for the GITHUB_TOKEN used in our
    GitHub Actions configuration to the minimum required to successfully
    run.
    mcdonnnj committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    8a77a8b View commit details
    Browse the repository at this point in the history
  2. Update pre-commit hook versions

    This is done automatically with the `pre-commit autoupdate` command.
    mcdonnnj committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    3b1d4ef View commit details
    Browse the repository at this point in the history
  3. Sort hook ids in each pre-commit hook entry

    Ensure that all hook ids are sorted alphabetically in each hook entry
    in our pre-commit configuration.
    mcdonnnj committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    1d285f2 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2024

  1. Merge pull request #189 from cisagov/improvement/manually_run_sync-la…

    …bels_workflow
    
    Allow the `sync-labels` workflow to be run manually
    mcdonnnj authored Oct 30, 2024
    Configuration menu
    Copy the full SHA
    5da1059 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #190 from cisagov/improvement/add_actions-permissi…

    …ons-monitor
    
    Add the `GitHubSecurityLab/actions-permissions/monitor` Action
    mcdonnnj authored Oct 30, 2024
    Configuration menu
    Copy the full SHA
    ff221ba View commit details
    Browse the repository at this point in the history
  3. Merge pull request #191 from cisagov/improvement/github_tokenn_polp

    Explicitly define permissions of `GITHUB_TOKEN` in our GitHub Actions workflows
    mcdonnnj authored Oct 30, 2024
    Configuration menu
    Copy the full SHA
    971602a View commit details
    Browse the repository at this point in the history
  4. Merge pull request #192 from cisagov/maintenance/update_pre-commit_hooks

    Update `pre-commit` hook versions
    mcdonnnj authored Oct 30, 2024
    Configuration menu
    Copy the full SHA
    bdf8a25 View commit details
    Browse the repository at this point in the history
  5. Merge pull request #193 from cisagov/improvement/add_more_pre-commit_…

    …hooks
    
    Add additional hooks from `pre-commit/pre-commit-hooks`
    mcdonnnj authored Oct 30, 2024
    Configuration menu
    Copy the full SHA
    6959971 View commit details
    Browse the repository at this point in the history
  6. Merge pull request #194 from cisagov/improvement/ensure_pre-commit_ho…

    …oks_are_sorted
    
    Sort hook ids in each `pre-commit` hook entry
    mcdonnnj authored Oct 30, 2024
    Configuration menu
    Copy the full SHA
    f517db7 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    ef51f4f View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    93d77a2 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2024

  1. Update the commented out dependabot ignore directives

    Add a directive for hashicorp/setup-packer that was missed when it was
    added to the `build` workflow. Add a directive for
    cisagov/setup-env-github-action that is not strictly necessary since we
    currently just pull from the `develop` branch, but is good to have in
    case we were to change that in the future.
    mcdonnnj committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    8824475 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #195 from cisagov/bug/add_missing_dependabot_ignore

    Add missing dependabot ignore directives
    mcdonnnj authored Nov 1, 2024
    Configuration menu
    Copy the full SHA
    e6afb68 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2024

  1. Configuration menu
    Copy the full SHA
    7f3cc80 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    35287ff View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2024

  1. Merge pull request #219 from cisagov/lineage/skeleton

    Lineage pull request for: skeleton
    mcdonnnj authored Nov 8, 2024
    Configuration menu
    Copy the full SHA
    e2722ef View commit details
    Browse the repository at this point in the history
  2. Merge pull request #221 from cisagov/improvement/specify-variables-as…

    …-non-nullable
    
    Specify all variables as non-`nullable`
    mcdonnnj authored Nov 8, 2024
    Configuration menu
    Copy the full SHA
    d0a08ae View commit details
    Browse the repository at this point in the history
  3. Loosen version constraints to allow more future versions

    This agrees with the advice for Terraform modules given here:
    https://developer.hashicorp.com/terraform/language/expressions/version-constraints#terraform-core-and-provider-versions
    
    Note that these changes should not be made to root modules.
    jsf9k authored and mcdonnnj committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    41d00ad View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c9d0d35 View commit details
    Browse the repository at this point in the history
  5. Merge pull request #220 from cisagov/improvement/loosen-version-restr…

    …ictions
    
    Loosen version restrictions
    mcdonnnj authored Nov 8, 2024
    Configuration menu
    Copy the full SHA
    e7315c0 View commit details
    Browse the repository at this point in the history
  6. Merge https://github.com/cisagov/skeleton-tf-module into lineage/skel…

    …eton
    mcdonnnj committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    286d265 View commit details
    Browse the repository at this point in the history