-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lineage pull request for: skeleton #31
Commits on Feb 14, 2024
-
Add checks for semantic python versions
Michael Saki committedFeb 14, 2024 Configuration menu - View commit details
-
Copy full SHA for 33582a1 - Browse repository at this point
Copy the full SHA 33582a1View commit details -
Refactor code for the semantic check
This commit will make a few changes. The orginal version of the semantic checking function was a bit more difficult to read. It is now somewhat easier to follow how the regex is structured. Also the function has been renamed to check_python_version since it has 2 functions, making sure that the version is semantically correct and the second is to make sure that it is installed on the user's machine. This makes it easier to follow the logic for the flags, -p or --python-version and -l or --list-versions
Michael Saki committedFeb 14, 2024 Configuration menu - View commit details
-
Copy full SHA for 9438194 - Browse repository at this point
Copy the full SHA 9438194View commit details
Commits on Mar 18, 2024
-
Add checks for semantic python versions
Michael Saki committedMar 18, 2024 Configuration menu - View commit details
-
Copy full SHA for cea8edc - Browse repository at this point
Copy the full SHA cea8edcView commit details -
Refactor code for the semantic check
This commit will make a few changes. The orginal version of the semantic checking function was a bit more difficult to read. It is now somewhat easier to follow how the regex is structured. Also the function has been renamed to check_python_version since it has 2 functions, making sure that the version is semantically correct and the second is to make sure that it is installed on the user's machine. This makes it easier to follow the logic for the flags, -p or --python-version and -l or --list-versions
Michael Saki committedMar 18, 2024 Configuration menu - View commit details
-
Copy full SHA for d5c7c4a - Browse repository at this point
Copy the full SHA d5c7c4aView commit details -
Merge branch 'improvement/correct-semantic-python-version-checks' of h…
…ttps://github.com/cisagov/skeleton-generic into improvement/correct-semantic-python-version-checks
Michael Saki committedMar 18, 2024 Configuration menu - View commit details
-
Copy full SHA for f7b9d05 - Browse repository at this point
Copy the full SHA f7b9d05View commit details -
Remove example of correct semantic version
Michael Saki committedMar 18, 2024 Configuration menu - View commit details
-
Copy full SHA for 327ab73 - Browse repository at this point
Copy the full SHA 327ab73View commit details
Commits on Mar 20, 2024
-
Refactor the error message for the user
Michael Saki committedMar 20, 2024 Configuration menu - View commit details
-
Copy full SHA for 4dedf50 - Browse repository at this point
Copy the full SHA 4dedf50View commit details -
Improve the semantic error message
Michael Saki committedMar 20, 2024 Configuration menu - View commit details
-
Copy full SHA for e84deea - Browse repository at this point
Copy the full SHA e84deeaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5fdc7be - Browse repository at this point
Copy the full SHA 5fdc7beView commit details
Commits on Mar 21, 2024
-
Refactor regex, add link, and improve comments
Michael Saki committedMar 21, 2024 Configuration menu - View commit details
-
Copy full SHA for 42ef8c2 - Browse repository at this point
Copy the full SHA 42ef8c2View commit details -
Update link to use semver.org over regex101.com
Michael Saki committedMar 21, 2024 Configuration menu - View commit details
-
Copy full SHA for a77e5e1 - Browse repository at this point
Copy the full SHA a77e5e1View commit details -
Co-authored-by: dav3r <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 5fe14c7 - Browse repository at this point
Copy the full SHA 5fe14c7View commit details
Commits on Apr 20, 2024
-
Add a meta hook to the pre-commit configuration
Add the `check-useless-excludes` meta hook to verify that any defined `exclude` directives apply to at least one file in the repository.
Configuration menu - View commit details
-
Copy full SHA for b7896a0 - Browse repository at this point
Copy the full SHA b7896a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 260566f - Browse repository at this point
Copy the full SHA 260566fView commit details
Commits on Jul 1, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a68994d - Browse repository at this point
Copy the full SHA a68994dView commit details
Commits on Aug 12, 2024
-
Use the hashicorp/setup-packer GitHub Action
Instead of manually installing Packer we can instead leverage the hashicorp/setup-packer Action just as we do for Terraform.
Configuration menu - View commit details
-
Copy full SHA for 43b91c7 - Browse repository at this point
Copy the full SHA 43b91c7View commit details
Commits on Aug 23, 2024
-
Remove @jasonodoom as a codeowner
He is no longer a member of @cisagov/vm-dev.
Configuration menu - View commit details
-
Copy full SHA for 8ada75d - Browse repository at this point
Copy the full SHA 8ada75dView commit details
Commits on Aug 26, 2024
-
Previously we only provided a lower bound for the version, but pinning to a specific version aligns with what has been done with the prettier hook and how pre-commit hooks are pinned in general. The flake8-docstrings package is rarely updated, so there is no real downside to pinning to a specific version. Co-authored-by: Nick <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 2930208 - Browse repository at this point
Copy the full SHA 2930208View commit details
Commits on Sep 24, 2024
-
Bump actions/cache from 3 to 4
Bumps [actions/cache](https://github.com/actions/cache) from 3 to 4. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@v3...v4) --- updated-dependencies: - dependency-name: actions/cache dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 46e0553 - Browse repository at this point
Copy the full SHA 46e0553View commit details -
Bump crazy-max/ghaction-github-status from 3 to 4
Bumps [crazy-max/ghaction-github-status](https://github.com/crazy-max/ghaction-github-status) from 3 to 4. - [Release notes](https://github.com/crazy-max/ghaction-github-status/releases) - [Commits](crazy-max/ghaction-github-status@v3...v4) --- updated-dependencies: - dependency-name: crazy-max/ghaction-github-status dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 3167421 - Browse repository at this point
Copy the full SHA 3167421View commit details
Commits on Sep 25, 2024
-
Update pre-commit hook versions
This is done automatically with the `pre-commit autoupdate` command. The pre-commit/mirrors-prettier hook was manually held back because the latest tags are for alpha releases of the next major version.
Configuration menu - View commit details
-
Copy full SHA for 6a58c2c - Browse repository at this point
Copy the full SHA 6a58c2cView commit details -
Manually update the prettier hook
Use the latest v3 release available from NPM.
Configuration menu - View commit details
-
Copy full SHA for 553efcb - Browse repository at this point
Copy the full SHA 553efcbView commit details -
Merge pull request #170 from cisagov/dependabot/github_actions/crazy-…
…max/ghaction-github-status-4 Bump crazy-max/ghaction-github-status from 3 to 4
Configuration menu - View commit details
-
Copy full SHA for 184e749 - Browse repository at this point
Copy the full SHA 184e749View commit details -
Merge pull request #171 from cisagov/dependabot/github_actions/action…
…s/cache-4 Bump actions/cache from 3 to 4
Configuration menu - View commit details
-
Copy full SHA for d99c117 - Browse repository at this point
Copy the full SHA d99c117View commit details -
Merge pull request #187 from cisagov/improvement/use_setup_packer_action
Use an Action to install Packer in our GitHub Actions workflows
Configuration menu - View commit details
-
Copy full SHA for 2491ca0 - Browse repository at this point
Copy the full SHA 2491ca0View commit details -
Merge pull request #176 from cisagov/improvement/correct-semantic-pyt…
…hon-version-checks Add checks for correct semantic version of Python
Configuration menu - View commit details
-
Copy full SHA for f6c9537 - Browse repository at this point
Copy the full SHA f6c9537View commit details -
Merge pull request #188 from cisagov/remove-odoom-as-a-codeowner
Remove @jasonodoom as a codeowner
Configuration menu - View commit details
-
Copy full SHA for 10e5f6f - Browse repository at this point
Copy the full SHA 10e5f6fView commit details -
Add a pre-commit hook to run pip-audit
The pip-audit tool will audit any supplied pip requirements files for vulnerable packages.
Configuration menu - View commit details
-
Copy full SHA for 045a998 - Browse repository at this point
Copy the full SHA 045a998View commit details -
Merge pull request #178 from cisagov/improvement/add_pre-commit_meta_…
…hook Add the `check-useless-excludes` hook to the pre-commit configuration
Configuration menu - View commit details
-
Copy full SHA for 28dc4ce - Browse repository at this point
Copy the full SHA 28dc4ceView commit details -
Merge pull request #179 from cisagov/improvement/add_pip-audit_pre-co…
…mmit_hook Add a pre-commit hook to run `pip-audit`
Configuration menu - View commit details
-
Copy full SHA for 5801cec - Browse repository at this point
Copy the full SHA 5801cecView commit details -
Merge pull request #184 from cisagov/improvement/pin-flake8-docstrings
Add a lower-bound pin for the `flake8-docstrings` `pip` package
Configuration menu - View commit details
-
Copy full SHA for e61255c - Browse repository at this point
Copy the full SHA e61255cView commit details -
Merge pull request #185 from cisagov/maintenance/update_pre-commit_hooks
Update `pre-commit` hooks
Configuration menu - View commit details
-
Copy full SHA for 44cd1be - Browse repository at this point
Copy the full SHA 44cd1beView commit details -
Use the rbubley/mirrors-prettier hook for prettier
This replaces the now archived pre-commit/mirrors-prettier hook.
Configuration menu - View commit details
-
Copy full SHA for c502f1a - Browse repository at this point
Copy the full SHA c502f1aView commit details -
Merge pull request #186 from cisagov/improvement/switch_prettier_hook
Switch the `pre-commit` hook used to run `prettier`
Configuration menu - View commit details
-
Copy full SHA for f0e55b3 - Browse repository at this point
Copy the full SHA f0e55b3View commit details
Commits on Oct 2, 2024
-
Add a new trigger for the sync-labels GitHub Actions workflow
Add a `workflow_dispatch` trigger so we can manually run the workflow if needed.
Configuration menu - View commit details
-
Copy full SHA for 942c0dc - Browse repository at this point
Copy the full SHA 942c0dcView commit details -
Configuration menu - View commit details
-
Copy full SHA for a267662 - Browse repository at this point
Copy the full SHA a267662View commit details -
Configuration menu - View commit details
-
Copy full SHA for dc7f09e - Browse repository at this point
Copy the full SHA dc7f09eView commit details
Commits on Oct 9, 2024
-
Specify all variables as non-nullable
This means that we need not worry about whether variables are explicitly specified as null. Since this is not something we were expecting, it makes sense to avoid the situation. See also: https://developer.hashicorp.com/terraform/language/values/variables#disallowing-null-input-values
Configuration menu - View commit details
-
Copy full SHA for 7bf438d - Browse repository at this point
Copy the full SHA 7bf438dView commit details -
Bump the required version of Terraform up to 1.1
Version 1.1 of Terraform is the first version to support the nullable key in variable definitions. Also update the comment associated with this line to something a bit more truthful, since we are using 1.5.7 in cisagov/setup-env-github-action. Co-authored-by: David Redmin <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c551420 - Browse repository at this point
Copy the full SHA c551420View commit details -
Update terraform-docs content in README.md
Co-authored-by: David Harris <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e57dd10 - Browse repository at this point
Copy the full SHA e57dd10View commit details -
Update version information and terraform-docs output for example code
Co-authored-by: David Harris <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 193083a - Browse repository at this point
Copy the full SHA 193083aView commit details
Commits on Oct 28, 2024
-
Add the GitHubSecurityLab/actions-permissions/monitor Action
This Action will provide information about the usage of GITHUB_TOKEN in the workflow. It should be added to _every_ job in _any_ workflow to provide information for analysis.
Configuration menu - View commit details
-
Copy full SHA for 343d2cc - Browse repository at this point
Copy the full SHA 343d2ccView commit details
Commits on Oct 29, 2024
-
Restrict permissions of GITHUB_TOKEN
This changes the default permissions for the GITHUB_TOKEN used in our GitHub Actions configuration to the minimum required to successfully run.
Configuration menu - View commit details
-
Copy full SHA for 8a77a8b - Browse repository at this point
Copy the full SHA 8a77a8bView commit details -
Update pre-commit hook versions
This is done automatically with the `pre-commit autoupdate` command.
Configuration menu - View commit details
-
Copy full SHA for 3b1d4ef - Browse repository at this point
Copy the full SHA 3b1d4efView commit details -
Sort hook ids in each pre-commit hook entry
Ensure that all hook ids are sorted alphabetically in each hook entry in our pre-commit configuration.
Configuration menu - View commit details
-
Copy full SHA for 1d285f2 - Browse repository at this point
Copy the full SHA 1d285f2View commit details
Commits on Oct 30, 2024
-
Merge pull request #189 from cisagov/improvement/manually_run_sync-la…
…bels_workflow Allow the `sync-labels` workflow to be run manually
Configuration menu - View commit details
-
Copy full SHA for 5da1059 - Browse repository at this point
Copy the full SHA 5da1059View commit details -
Merge pull request #190 from cisagov/improvement/add_actions-permissi…
…ons-monitor Add the `GitHubSecurityLab/actions-permissions/monitor` Action
Configuration menu - View commit details
-
Copy full SHA for ff221ba - Browse repository at this point
Copy the full SHA ff221baView commit details -
Merge pull request #191 from cisagov/improvement/github_tokenn_polp
Explicitly define permissions of `GITHUB_TOKEN` in our GitHub Actions workflows
Configuration menu - View commit details
-
Copy full SHA for 971602a - Browse repository at this point
Copy the full SHA 971602aView commit details -
Merge pull request #192 from cisagov/maintenance/update_pre-commit_hooks
Update `pre-commit` hook versions
Configuration menu - View commit details
-
Copy full SHA for bdf8a25 - Browse repository at this point
Copy the full SHA bdf8a25View commit details -
Merge pull request #193 from cisagov/improvement/add_more_pre-commit_…
…hooks Add additional hooks from `pre-commit/pre-commit-hooks`
Configuration menu - View commit details
-
Copy full SHA for 6959971 - Browse repository at this point
Copy the full SHA 6959971View commit details -
Merge pull request #194 from cisagov/improvement/ensure_pre-commit_ho…
…oks_are_sorted Sort hook ids in each `pre-commit` hook entry
Configuration menu - View commit details
-
Copy full SHA for f517db7 - Browse repository at this point
Copy the full SHA f517db7View commit details -
Configuration menu - View commit details
-
Copy full SHA for ef51f4f - Browse repository at this point
Copy the full SHA ef51f4fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 93d77a2 - Browse repository at this point
Copy the full SHA 93d77a2View commit details
Commits on Nov 1, 2024
-
Update the commented out dependabot ignore directives
Add a directive for hashicorp/setup-packer that was missed when it was added to the `build` workflow. Add a directive for cisagov/setup-env-github-action that is not strictly necessary since we currently just pull from the `develop` branch, but is good to have in case we were to change that in the future.
Configuration menu - View commit details
-
Copy full SHA for 8824475 - Browse repository at this point
Copy the full SHA 8824475View commit details -
Merge pull request #195 from cisagov/bug/add_missing_dependabot_ignore
Add missing dependabot ignore directives
Configuration menu - View commit details
-
Copy full SHA for e6afb68 - Browse repository at this point
Copy the full SHA e6afb68View commit details
Commits on Nov 5, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 7f3cc80 - Browse repository at this point
Copy the full SHA 7f3cc80View commit details -
Configuration menu - View commit details
-
Copy full SHA for 35287ff - Browse repository at this point
Copy the full SHA 35287ffView commit details
Commits on Nov 8, 2024
-
Merge pull request #219 from cisagov/lineage/skeleton
Lineage pull request for: skeleton
Configuration menu - View commit details
-
Copy full SHA for e2722ef - Browse repository at this point
Copy the full SHA e2722efView commit details -
Merge pull request #221 from cisagov/improvement/specify-variables-as…
…-non-nullable Specify all variables as non-`nullable`
Configuration menu - View commit details
-
Copy full SHA for d0a08ae - Browse repository at this point
Copy the full SHA d0a08aeView commit details -
Loosen version constraints to allow more future versions
This agrees with the advice for Terraform modules given here: https://developer.hashicorp.com/terraform/language/expressions/version-constraints#terraform-core-and-provider-versions Note that these changes should not be made to root modules.
Configuration menu - View commit details
-
Copy full SHA for 41d00ad - Browse repository at this point
Copy the full SHA 41d00adView commit details -
Configuration menu - View commit details
-
Copy full SHA for c9d0d35 - Browse repository at this point
Copy the full SHA c9d0d35View commit details -
Merge pull request #220 from cisagov/improvement/loosen-version-restr…
…ictions Loosen version restrictions
Configuration menu - View commit details
-
Copy full SHA for e7315c0 - Browse repository at this point
Copy the full SHA e7315c0View commit details -
Merge https://github.com/cisagov/skeleton-tf-module into lineage/skel…
…eton
mcdonnnj committedNov 8, 2024 Configuration menu - View commit details
-
Copy full SHA for 286d265 - Browse repository at this point
Copy the full SHA 286d265View commit details