Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propose a feasible way to add/remove plugins #27

Open
gameloser opened this issue Oct 10, 2024 · 2 comments
Open

Propose a feasible way to add/remove plugins #27

gameloser opened this issue Oct 10, 2024 · 2 comments
Labels
enhancement New feature or request question Further information is requested stale

Comments

@gameloser
Copy link

gameloser commented Oct 10, 2024

Problem Statement

From the roadmap

  • Plugin versions
  • Dynamically add or remove plugins at build time (to reduce binary size)

Proposed Solution

Instead of packing plugins to binary, making per plugin per image, refer to kuberhealthy's daemonset-check. The plugin manager in Agent will also need some adjustments.

Alternatives Considered

Additional Context

@subbaksh
Copy link
Contributor

subbaksh commented Nov 13, 2024

Yeah, The design decision not to create new pods for every test is deliberate. This is because when there are 1000s of tests, it puts a lot of load on the apiserver. So we wanted each test run and plugin to have relatively small costs in terms of compute and memory, as well as the number of requests to the api server. But there could be a compromise where you deploy a new plugin as a new pod, which gets invoked by pluginmanager at set intervals. Good suggestion!

@subbaksh subbaksh added enhancement New feature or request question Further information is requested labels Nov 28, 2024
Copy link

github-actions bot commented Feb 1, 2025

Thank you for your contribution! This issue has been automatically marked as stale because it has no recent activity in the last 60 days. It will be closed in 7 days, if no further activity occurs. If this issue is still relevant, please leave a comment to let us know, and the stale label will be automatically removed.

@github-actions github-actions bot added the stale label Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested stale
Projects
None yet
Development

No branches or pull requests

2 participants