Segregate unconfirmed balance from confirmed ones in Balance struct

[rishkwal]

Currently if you use taker get-balances to fetch the balance of taker's wallet it shows unconfirmed balance as spendable:

get-balances
{
  "contract": 0,
  "regular": 10000000,
  "spendable": 10000000,
  "swap": 0
}

list-utxo
{
  "addr": "bcrt1qd3wxljjc4v9f7v3rfugnvat0fqzewrtc2ytr40",
  "amount": 5000000,
  "confirmations": 0,
  "utxo_type": "regular"
}
{
  "addr": "bcrt1qd3wxljjc4v9f7v3rfugnvat0fqzewrtc2ytr40",
  "amount": 5000000,
  "confirmations": 0,
  "utxo_type": "regular"
}

We should add another field to discern unconfirmed balance from spendable balance.
Something like:

get-balances
{
  "contract": 0,
  "regular": 10000000,
  "spendable": 0,
  "unconfirmed": 10000000,
  "swap": 0
}

[mojoX911]

Yes we can do that. But unconfirmed are also spendable. I don't have a strong opinion either way, this will required another API in the wallet to filter only unconfirmed utxos.

[khadar1020]

I would like to take up this issue

[KnowWhoami]

I think it's good to segregate unconfirmed utxo balance from the confirmed ones as a part of enhancement in cli-apps.

But my question is :
Is it good to have a single unconfirmed balance section to denote balance of any UTXO type?

I don't have a strong opinion either way, this will required another API in the wallet to filter only unconfirmed utxos.

IMO, we just need to modify get_balance api for this task.

coinswap/src/wallet/api.rs

Lines 325 to 353 in d38fc63

	pub fn get_balances(
	&self,
	all_utxos: Option<&Vec<ListUnspentResultEntry>>,
	) -> Result<Balances, WalletError> {
	let regular = self
	.list_descriptor_utxo_spend_info(all_utxos)?
	.iter()
	.fold(Amount::ZERO, |sum, (utxo, _)| sum + utxo.amount);
	let contract = self
	.list_live_timelock_contract_spend_info(all_utxos)?
	.iter()
	.fold(Amount::ZERO, |sum, (utxo, _)| sum + utxo.amount);
	let swap = self
	.list_incoming_swap_coin_utxo_spend_info(all_utxos)?
	.iter()
	.fold(Amount::ZERO, |sum, (utxo, _)| sum + utxo.amount);
	let fidelity = self
	.list_fidelity_spend_info(all_utxos)?
	.iter()
	.fold(Amount::ZERO, |sum, (utxo, _)| sum + utxo.amount);
	let spendable = regular + swap;
	Ok(Balances {
	regular,
	swap,
	contract,
	fidelity,
	spendable,
	})

[KnowWhoami]

But unconfirmed are also spendable

modified the issue title.

[Sansh2356]

Is this issue still pending can i take it up?

[KnowWhoami]

Currently we have not come to any sort of conclusion regarding it...
So would prefer to skip this issue for now. There are other important stuffs that you can pick up..