Include files from "extra-files" folder #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(DON’T MERGE)
@dstillman, we got a request to include a “composer.json” file to the CSL styles repo, for the PHP dependency manager Composer. We thought it made most sense to put it in “styles-distribution”, and I thought we could have the distribution-updater add the file.
The distribution-updater script currently contains an embedded README, so I changed the script to copy over any files within the “extra-files” directory, which will later include the README and this composer.json file.
scripts/styles_distribution.pyworks right now, but this PR currently breaksscripts/webapp.py. I wasn’t sure what the right way was to define the path to the “extra-files” directory (EXTRA_FILES_DIRECTORY) so it works in both scripts, so I was hoping you could give me a pointer for that. I noticed thatstyles_distribution.pydidn’t use any relative paths to the script itself, and I wasn’t sure if there was a reason for that.